Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs electron-prebuilt-compile 4.0.0 by default, which fails ember electron:make -prod #384

Closed
DanLeininger opened this issue Mar 19, 2019 · 3 comments

Comments

@DanLeininger
Copy link

A fresh install, with ember-cli 3.8.1:

ember new my-project
ember install ember-electron

Installs

"electron-prebuilt-compile": "4.0.0",

Which then causes

ember electron:make -prod

To fail with

ENOENT: no such file or directory, open '/var/folders/pq/3zy6j6_n3hz_1wkgdxznzbz40000gq/T/electron-packager/darwin-x64/MyProject-darwin-x64/Electron.app/Contents/Frameworks/Electron Helper EH.app/Contents/Info.plist'


Stack Trace and Error Report: /var/folders/pq/3zy6j6_n3hz_1wkgdxznzbz40000gq/T/error.dump.a7eaaf95c3da4f49ad047b0700e67651.log

This will build if you downgrade electron-prebuilt-compile to the latest 3.0.x

"electron-prebuilt-compile": "3.0.13",
@jacobq
Copy link
Collaborator

jacobq commented Mar 19, 2019

@DanLeininger Thanks for pointing this out. Maybe we should pin it until electron-userland/electron-prebuilt-compile#77 is resolved. I wish so much that epc had automatic releases or that ef would work easily with forks.

@RobbieTheWagner
Copy link
Member

This should be fixed with the updates to electron-forge we just merged in #418

@RobbieTheWagner
Copy link
Member

@bendemboski should we close this now that v3 beta is out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants