Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember electron {make, package} fails on darwin builds #399

Closed
3 tasks done
cupofnestor opened this issue Aug 7, 2019 · 4 comments
Closed
3 tasks done

ember electron {make, package} fails on darwin builds #399

cupofnestor opened this issue Aug 7, 2019 · 4 comments

Comments

@cupofnestor
Copy link

cupofnestor commented Aug 7, 2019

Relevant:

electron/packager#927
#384

We are having the same trouble as these folks. Here is what I've tried:

  • npm install [email protected]
    :make fails
  • npm update ember-electron
    :make fails
  • npm r electron-prebuilt-compile && npm i --save-dev [email protected]
    :make succeeds

Why do we need to downgrade prebuilt-compile, whose dep is this?
What is the best course of action to support my devs? - modify package.json in the ember project to v3.0.13?

@jacobq
Copy link
Collaborator

jacobq commented Aug 9, 2019

Although I don't have easy access to Mac machines to test, I suspect this is related to the problems (e.g. see this comment) I've had that mostly boil down to (1) electron-prebuilt-compile (required by electron-forge v5.x) being abandoned and (2) electron-forge v6.0.0 not being released yet. If downgrading solves your problem for now then that is probably the most expedient "solution". However, what I think we (users/contributors to ember-electron) really need to do is to update the codebase to use electron-forge 6 (beta). That should help break some long-standing log-jams.

@RobbieTheWagner
Copy link
Member

@jacobq I believe this should be fixed with the electron-forge updates right?

@RobbieTheWagner
Copy link
Member

@bendemboski should we close this now that v3 beta is out?

@bendemboski
Copy link
Member

In the 3.0 beta we're on the latest electron-forge and electron-packager. If you update and it's still happen, feel free to reopen or open a new issue with updating info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants