MWPW-160157 Dispatch error to alert for missing IMS token #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MWPW-156696 | Fixing the render issue Before: https://main--unity--adobecom.hlx.page/unity/unitypages/test-and-demo?georouting=off&martech=off After: https://imagerender--unity--adobecom.hlx.page/unity/unitypages/test-and-demo?georouting=off&martech=off Test url: https://stage--cc--adobecom.hlx.page/products/photoshop/remove-background?unitylibs=imagerender
* Upload a pdf from UI * Create chunks to upload on temp urls * Connector api call for acrobat.
Animation loader for unity
- Map upload and drag & drop functionality - Extract limits outside of actionMap in config
1. Add config support for multiple block support 2. Keep v1 support for live test page 3. Add v2 with config support https://main--cc--adobecom.hlx.live/products/photoshop/remove-background?unitylibs=refactor https://main--cc--adobecom.hlx.page/drafts/mathuria/unity/poc?unitylibs=refactor&unityversion=v2
- Centralized error handling in Unity UI - Perform one-time storing of error map in window object for fast lookups downstream - Created fillsign actionType to consolidate config and break code out into a singleFileUpload function (multiFileUpload can be implemented based on future needs)
* Send analytics for acrobat fiil and sign Resolves: [MWPW-158477](https://jira.corp.adobe.com/browse/MWPW-158477) **Test URLs:** - Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=stage - After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=MWPW-158477
Co-authored-by: Sanjay Saravanan <[email protected]>
Adding check for asset metadata to verify and dispatch an error if the number of pages for the uploaded PDF asset exceeds the max limit. Resolves: [MWPW-159153](https://jira.corp.adobe.com/browse/MWPW-159153) **Test URLs:** - Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=stage - After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=MWPW-159153
Adding error handling for storage exceeded and no storage provisioned errors. Resolves: [MWPW-159861](https://jira.corp.adobe.com/browse/MWPW-159861) Test URLs: Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=stage After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=MWPW-159861
fix issue of file greater than 100 MB getting uploaded Resolves: [MWPW-160227](https://jira.corp.adobe.com/browse/MWPW-160227) Test URLs: Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=stage After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=MWPW-160227
Update splash screen fragment path Resolves: [MWPW-160059](https://jira.corp.adobe.com/browse/MWPW-160059) Test URLs: Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=stage After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?unitylibs=MWPW-160059
Ensure metadata page count is checked even after interval timeout if asset metadata exists. Also, reset operations array if `verifyContent` fails so that redirection to product is interrupted. Resolves: [MWPW-159947](https://jira.corp.adobe.com/browse/MWPW-159947) Test URLs: Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf?unitylibs=stage After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf?unitylibs=MWPW-159947
Adding timeout to finalize API request and including status code when dispatching errors associated with timeouts. Resolves: [MWPW-160229](https://jira.corp.adobe.com/browse/MWPW-160229) Test URLs: Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf?unitylibs=stage After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf?unitylibs=MWPW-160229
MWPW-159951 | Stop scrolling when splash screen is visible Resolves: MWPW-159951
Splash screen is not over the jarvis chat if same is enabled on the page. Increasing the z-index to be over jarvis. Resolves: MWPW-159953
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
robert-bogos
approved these changes
Oct 23, 2024
Comment on lines
+19
to
+23
| if (!gat) { | ||
| const error = new Error(); | ||
| error.message = 'imsError'; | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
Nit: You can do this in 1 line
Suggested change
| if (!gat) { | |
| const error = new Error(); | |
| error.message = 'imsError'; | |
| throw error; | |
| } | |
| if (!gat) throw Object.assign(new Error(), { message: 'imsError' }); |
narcis-radu
approved these changes
Oct 23, 2024
sanjayms01
force-pushed
the
stage
branch
3 times, most recently
from
3a0e2c8 to
20711cc
Compare
aishwaryamathuria
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatching an error when IMS token is missing. Will work with PMs to understand what messaging should be authored for this error.
Resolves: MWPW-160157
Test URLs:
Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf?unitylibs=stage
After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf?unitylibs=MWPW-160157