Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breadcrumb)!: spectrum 2 migration #3395

Open
wants to merge 9 commits into
base: spectrum-two
Choose a base branch
from

Commits on Nov 13, 2024

  1. fix(breadcrumb): latest breadcrumb css and template from main

    Current changes on main, including bugfixes, to assist with testing with
    s2, until the base branch is updated with main.
    jawinn committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e51e4ca View commit details
    Browse the repository at this point in the history
  2. feat(breadcrumb): density renaming and set bulk of new s2 values

    The options and naming around densities has changed in s2. There is now:
    - Medium / default (was previously "compact")
    - Large (was previously default)
    - Multiline (existing)
    
    This updates the controls, classes, and tokens around that.
    
    It also sets the bulk of the new values for existing custom properties
    that have changed in s2.
    jawinn committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f0d0d6f View commit details
    Browse the repository at this point in the history
  3. refactor(breadcrumb): simplify layout custom properties and css

    Leverage changing custom property values for --large and --multiline,
    instead of creating new properties for every variant. This reduces the
    number of custom properties and slims down the CSS.
    jawinn committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    16fe50e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    28e7fd2 View commit details
    Browse the repository at this point in the history
  5. docs(breadcrumb): some stories from main for testing

    Pulls in most of the stories from main, and changes compact stories to
    large stories--
    
    This commit can be modified or dropped once spectrum-two is up to date
    with all of the stories and template changes on main. This excludes
    BreadcrumbGroup, test.js, etc.
    jawinn committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2b6372c View commit details
    Browse the repository at this point in the history
  6. feat(breadcrumb): finalize s2 changes

    Finalize use of s2 tokens defined in design, including new tokens and
    changes. Adjusts which multiline tokens are applied.
    jawinn committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d95d895 View commit details
    Browse the repository at this point in the history
  7. feat(breadcrumb): add support for multiline headings

    The new specs specified that title item can be customized in the
    multiline variant, with preferred sizing. This adds support for that
    in our template and adds a new Storybook control.
    jawinn committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a819f2b View commit details
    Browse the repository at this point in the history
  8. fix(breadcrumb): spacing adjustments to meet spec

    Adjusts some spacings and the tokens used to make sure that this is
    adhering to the tokens defined on the design spec.
    
    Of note, this helps fix:
    - Too much horizontal spacing beside truncated menu; there needed to be
      different spacing for text to separator and truncated menu to
      separator. To allow this be changed, some margins/paddings were
      moved around to different elements than before.
    - Uses correct start edge spacing (previously padding on the ul), which
      needs to be different for text items and the truncated menu item.
    jawinn committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    24f863b View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. fix(breadcrumb): update height token and remove unused properties

    - update component height token used
    - remove two unused custom properties
    jawinn committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    74ba42e View commit details
    Browse the repository at this point in the history