-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breadcrumb)!: spectrum 2 migration #3395
base: spectrum-two
Are you sure you want to change the base?
Commits on Nov 13, 2024
-
fix(breadcrumb): latest breadcrumb css and template from main
Current changes on main, including bugfixes, to assist with testing with s2, until the base branch is updated with main.
Configuration menu - View commit details
-
Copy full SHA for e51e4ca - Browse repository at this point
Copy the full SHA e51e4caView commit details -
feat(breadcrumb): density renaming and set bulk of new s2 values
The options and naming around densities has changed in s2. There is now: - Medium / default (was previously "compact") - Large (was previously default) - Multiline (existing) This updates the controls, classes, and tokens around that. It also sets the bulk of the new values for existing custom properties that have changed in s2.
Configuration menu - View commit details
-
Copy full SHA for f0d0d6f - Browse repository at this point
Copy the full SHA f0d0d6fView commit details -
refactor(breadcrumb): simplify layout custom properties and css
Leverage changing custom property values for --large and --multiline, instead of creating new properties for every variant. This reduces the number of custom properties and slims down the CSS.
Configuration menu - View commit details
-
Copy full SHA for 16fe50e - Browse repository at this point
Copy the full SHA 16fe50eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28e7fd2 - Browse repository at this point
Copy the full SHA 28e7fd2View commit details -
docs(breadcrumb): some stories from main for testing
Pulls in most of the stories from main, and changes compact stories to large stories-- This commit can be modified or dropped once spectrum-two is up to date with all of the stories and template changes on main. This excludes BreadcrumbGroup, test.js, etc.
Configuration menu - View commit details
-
Copy full SHA for 2b6372c - Browse repository at this point
Copy the full SHA 2b6372cView commit details -
feat(breadcrumb): finalize s2 changes
Finalize use of s2 tokens defined in design, including new tokens and changes. Adjusts which multiline tokens are applied.
Configuration menu - View commit details
-
Copy full SHA for d95d895 - Browse repository at this point
Copy the full SHA d95d895View commit details -
feat(breadcrumb): add support for multiline headings
The new specs specified that title item can be customized in the multiline variant, with preferred sizing. This adds support for that in our template and adds a new Storybook control.
Configuration menu - View commit details
-
Copy full SHA for a819f2b - Browse repository at this point
Copy the full SHA a819f2bView commit details -
fix(breadcrumb): spacing adjustments to meet spec
Adjusts some spacings and the tokens used to make sure that this is adhering to the tokens defined on the design spec. Of note, this helps fix: - Too much horizontal spacing beside truncated menu; there needed to be different spacing for text to separator and truncated menu to separator. To allow this be changed, some margins/paddings were moved around to different elements than before. - Uses correct start edge spacing (previously padding on the ul), which needs to be different for text items and the truncated menu item.
Configuration menu - View commit details
-
Copy full SHA for 24f863b - Browse repository at this point
Copy the full SHA 24f863bView commit details
Commits on Dec 2, 2024
-
fix(breadcrumb): update height token and remove unused properties
- update component height token used - remove two unused custom properties
Configuration menu - View commit details
-
Copy full SHA for 74ba42e - Browse repository at this point
Copy the full SHA 74ba42eView commit details