Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typography): add fallback sizes for testing #3198

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Oct 2, 2024

Description

In the Typography storybook, allow typography elements to gracefully fallback to the next closest size when an invalid size is provided.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Visit the typography storybook page here:

  • @pfulton At the extra-extra-small size, expect the spectrum-Body and spectrum-Code snippets to use the sizeXS class.
  • @pfulton At the extra-small size, expect the spectrum-Detail snippet to use the sizeS class.
  • @pfulton At the extra-extra-large size, expect the spectrum-Detail and spectrum-Code snippets to use the sizeXL class.
  • @pfulton At the extra-extra-extra-large size, expect the spectrum-Detail and spectrum-Code snippets to use the sizeXL class.
  • Expect to see updates to VRT baselines for typography sizing.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • If my change impacts other components, I have tested to make sure they don't break.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: 8f35a00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe self-assigned this Oct 2, 2024
@castastrophe castastrophe added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) storybook labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

🚀 Deployed on https://pr-3198--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 2, 2024

File metrics

Summary

Total size: 4.31 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe marked this pull request as ready for review October 2, 2024 21:41
@castastrophe castastrophe force-pushed the chore-typography-fallback-sizes branch from 435df00 to 161fc46 Compare October 4, 2024 16:21
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Oct 4, 2024
@castastrophe castastrophe force-pushed the chore-typography-fallback-sizes branch from 161fc46 to 2933003 Compare October 4, 2024 18:12
@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Oct 4, 2024
@castastrophe castastrophe force-pushed the chore-typography-fallback-sizes branch from 2933003 to 83379a3 Compare October 4, 2024 20:01
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@castastrophe castastrophe force-pushed the chore-typography-fallback-sizes branch from 83379a3 to 8f35a00 Compare October 8, 2024 17:20
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT ready-to-merge and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Oct 8, 2024
@castastrophe castastrophe enabled auto-merge (squash) October 8, 2024 17:28
@castastrophe castastrophe merged commit e68e2aa into main Oct 8, 2024
28 of 34 checks passed
@castastrophe castastrophe deleted the chore-typography-fallback-sizes branch October 8, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge run_vrt For use on PRs looking to kick off VRT size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants