-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(typography): add fallback sizes for testing #3198
Conversation
|
🚀 Deployed on https://pr-3198--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.31 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
435df00
to
161fc46
Compare
161fc46
to
2933003
Compare
2933003
to
83379a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
83379a3
to
8f35a00
Compare
Description
In the Typography storybook, allow typography elements to gracefully fallback to the next closest size when an invalid size is provided.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Visit the typography storybook page here:
sizeXS
class.sizeS
class.sizeXL
class.sizeXL
class.Regression testing
Validate:
To-do list