docs(actiongroup): migrating docs to storybook #3160
Conversation
|
File metricsSummaryTotal size: 4.31 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-3160--spectrum-css.netlify.app |
There was a problem hiding this comment.
This looks really nice! I really like the way that you've grouped things (with the default, icon-only, quiet variants all together) to keep the number of variants from feeling overwhelming or confusing. I also really like that there are lots of examples (particularly in the sizing) of icons & text together in an action button. And the Overflow section and testing coverage is such a great addition! Overall this is such a huge improvement over the old docs site.
There were two small things I noticed that I think could use improvement, but I'm happy to hear arguments to the contrary:
- We're not showing the emphasized variant for action group. Since we generally do show it for components that have it, and there's a control for it, and we're testing it, it seems like something we ought to be displaying on our Docs page.
- For testing coverage, there are lots of variants, I don't know that every single combination needs to be tested (for instance icon-only compact, or compact quiet, or justified compact, etc.), but one case that I think would be beneficial would be more for vertical action groups, particularly vertical compact.
There was a problem hiding this comment.
Nice work, this one is coming along!
I think I agree with Rise, that if we're testing the isEmphasized, maybe we should showcase it on the docs page. (which I think you actually just pushed up a fix for). I had some similar thoughts around the isDisabled.
I had some comments on adding controls too, so let me know what you think!
| HorizontalSizing.parameters = { | ||
| chromatic: { disableSnapshot: true }, | ||
| }; |
There was a problem hiding this comment.
Whoops- this is duplicated on this story.
There was a problem hiding this comment.
@aramos-adobe thanks for making all of the updates! This looks fantastic! I think all of the additions gives users so much context and explanation for this component now, in comparison to the current docs site!
I did a quick check of the CHANGELOG and I think the migration guide is all included, so boom- approved!
aramos-adobe
deleted the
aramos-adobe/css928-actiongroup-migration-docs
branch
Description
Adding horizontal, vertical, and justified layouts
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list