Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cwv): lcp and cls collection feature parity with 1.x #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ekremney
Copy link
Member

@ekremney ekremney commented Dec 3, 2024

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

Copy link

aem-code-sync bot commented Dec 3, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@ekremney ekremney requested a review from trieloff December 3, 2024 09:27
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (102f76d) to head (e80fb5b).

Files with missing lines Patch % Lines
modules/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   86.74%   87.16%   +0.41%     
==========================================
  Files           6        6              
  Lines         596      592       -4     
==========================================
- Hits          517      516       -1     
+ Misses         79       76       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants