Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audience): validate and anonymize reported audience #235

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ramboz
Copy link
Collaborator

@ramboz ramboz commented Jul 17, 2024

Introducing data validation and pre-processing logic to properly validate experiment and audience checkpoints, which will be dependent on the opt-in logic, and also pre-process the reported audience to anonymize it.

Related Issues

Fix adobe/helix-rum-collector#360

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 92.78351% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.79%. Comparing base (8805b49) to head (43f6233).
Report is 1 commits behind head on main.

Files Patch % Lines
modules/index.js 85.71% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #235      +/-   ##
===========================================
- Coverage   100.00%   98.79%   -1.21%     
===========================================
  Files            6        6              
  Lines          488      583      +95     
===========================================
+ Hits           488      576      +88     
- Misses           0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right direction. One note: as it is written it still assumes that you'd call sampleRUM('audience') in your application code. We'd like to change the model so that you never have to call sampleRUMwhich means we need to find a way to carry the audience membership through the DOM. One way could be to have adata-` attribute at the body. If that's present, we assume there is an audience.

modules/index.js Outdated Show resolved Hide resolved
modules/index.js Outdated Show resolved Hide resolved
@ramboz
Copy link
Collaborator Author

ramboz commented Jul 19, 2024

@trieloff I can work with the DOM. We do set a CSS class for any experiment and/or audience so code-only ones can trigger appropriately. So I could hook into that logic and skip the explicit sampleRUM call indeed

@adobe-bot
Copy link
Collaborator

This PR will trigger a minor release when merged.

@ramboz ramboz marked this pull request as ready for review July 22, 2024 18:40
@ramboz
Copy link
Collaborator Author

ramboz commented Sep 16, 2024

@trieloff Is there anything left before we can approve and merge this?
I see 1 failing test, but that seems related to the newly introduced language checkpoint.

@trieloff
Copy link
Contributor

Good to merge when the conflicts have been resolved.

@ramboz
Copy link
Collaborator Author

ramboz commented Nov 5, 2024

@trieloff Looks like I hit the size limit with those changes. How do you want to proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking audiences in a privacy-first manner
3 participants