-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(audience): validate and anonymize reported audience #235
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
===========================================
- Coverage 100.00% 98.79% -1.21%
===========================================
Files 6 6
Lines 488 583 +95
===========================================
+ Hits 488 576 +88
- Misses 0 7 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right direction. One note: as it is written it still assumes that you'd call sampleRUM('audience') in your application code. We'd like to change the model so that you never have to call
sampleRUMwhich means we need to find a way to carry the audience membership through the DOM. One way could be to have a
data-` attribute at the body. If that's present, we assume there is an audience.
@trieloff I can work with the DOM. We do set a CSS class for any experiment and/or audience so code-only ones can trigger appropriately. So I could hook into that logic and skip the explicit sampleRUM call indeed |
This PR will trigger a minor release when merged. |
@trieloff Is there anything left before we can approve and merge this? |
Good to merge when the conflicts have been resolved. |
@trieloff Looks like I hit the size limit with those changes. How do you want to proceed? |
Introducing data validation and pre-processing logic to properly validate
experiment
andaudience
checkpoints, which will be dependent on the opt-in logic, and also pre-process the reported audience to anonymize it.Related Issues
Fix adobe/helix-rum-collector#360