Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore "fix: nested lists roundtrip (#530)" #556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

buuhuu
Copy link
Collaborator

@buuhuu buuhuu commented Oct 2, 2024

This restores commit e27ba08 which had been reverted in 88392b9.

The problem this caused last time with experience league got addressed, however we should do another round of testing.

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Fixes #529

Thanks for contributing!

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5be61ba) to head (4c1bb6a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #556   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines          797       825   +28     
  Branches         1         1           
=========================================
+ Hits           797       825   +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 2, 2024

This PR will trigger a patch release when merged.

@buuhuu buuhuu changed the title fix: Revert "Revert "fix: Revert "fix: nested lists roundtrip" (#539)"" fix: Restore "fix: nested lists roundtrip (#530)" Oct 2, 2024
@auniverseaway
Copy link
Member

FWIW: We (DA) would love to have this merged sooner rather than later.

@buuhuu buuhuu marked this pull request as ready for review December 4, 2024 08:59
@tripodsan
Copy link
Contributor

@buuhuu did you check with experience-league if their code now works with collapsed lists?

@buuhuu
Copy link
Collaborator Author

buuhuu commented Dec 4, 2024

I tested this with their dev env, but probably worth another iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists and nested lists are not roundtripable
3 participants