Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support x-html2md-img-src header #273

Merged
merged 13 commits into from
Aug 29, 2023
Merged

feat: support x-html2md-img-src header #273

merged 13 commits into from
Aug 29, 2023

Conversation

buuhuu
Copy link
Collaborator

@buuhuu buuhuu commented Aug 25, 2023 •
edited by tripodsan
Loading

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

buuhuu and others added 5 commits August 25, 2023 10:47
@buuhuu
feat: support x-html2md-img-src header
74c1e87 
This header controls which image soruces can be trusted. html2md will fetch and upload all images from these allowed sources. Images from unallowed sources will be kept untouched.
@buuhuu @tripodsan
fix: more tolerant split
15f7e6a 
Co-authored-by: Tobias Bocanegra <[email protected]>
@buuhuu
fix: allways apply 'self' as img-src policy
85533c4
@buuhuu
chore: add test coverage
830f0fc
@buuhuu
chore: add test coverage
786c884
@github-actions
Copy link

This PR will trigger a minor release when merged.

@buuhuu buuhuu marked this pull request as ready for review August 25, 2023 17:51
@buuhuu buuhuu requested a review from tripodsan August 25, 2023 17:51
@buuhuu @tripodsan
feat: support x-html2md-img-src header
ba24af1 
This header controls which image soruces can be trusted. html2md will fetch and upload all images from these allowed sources. Images from unallowed sources will be kept untouched.

Fixes: #268

Co-authored-by: Tobias Bocanegra <[email protected]>
@buuhuu buuhuu force-pushed the x-html2md-media-src branch from 786c884 to ba24af1 Compare August 25, 2023 17:54
tripodsan
tripodsan requested changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix code style
  • don't change test logic; prefer to add option to disable cache (eg. process.env.MEDIAHANDLER_DISABLE_CACHE)

test/index.test.js Outdated Show resolved Hide resolved
test/index.test.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/mdast-process-images.js Outdated Show resolved Hide resolved
@buuhuu buuhuu requested a review from tripodsan August 29, 2023 05:08
@tripodsan tripodsan merged commit 2ad20ba into main Aug 29, 2023
3 checks passed
@tripodsan tripodsan deleted the x-html2md-media-src branch August 29, 2023 15:29
trieloff pushed a commit that referenced this pull request Aug 29, 2023
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
cee3b0f 
# [2.1.0](v2.0.44...v2.1.0) (2023-08-29)

### Features

* support x-html2md-img-src header ([#273](#273)) ([2ad20ba](2ad20ba)), closes [#268](#268)
@trieloff
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tripodsan tripodsan tripodsan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buuhuu @trieloff @tripodsan