Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default health probe binding address in helm chart #83

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

adriananeci
Copy link
Contributor

Description

There is a discrepancy between clusterRegistryClient.health.healthProbeBindAddress (defaults to 8081) and readiness/liveness probes port (defaults to 9091) default value

The health probe server is listening

2023-10-16T19:20:44Z	INFO	Starting server	{"kind": "health probe", "addr": "[::]:8081"}

while the liveness/readiness probes are checked on

  Warning  Unhealthy  6s    kubelet            Readiness probe failed: Get "http://172.16.18.218:9091/readyz": dial tcp 172.16.18.218:9091: connect: connection refused

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adriananeci adriananeci requested a review from a team as a code owner October 16, 2023 19:44
Copy link

@JonnieDoe JonnieDoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know why the test fails. But the change is OK.

/lgtm

@victorvarza victorvarza merged commit c5b133b into adobe:main Oct 17, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants