Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude options, variants and variant attributes tables if simple product #55

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

dylandepass
Copy link
Contributor

No description provided.

@dylandepass
Copy link
Contributor Author

At this point we are assuming every product is a configurable. So pricing only exists in the product-variants table. For simple products we need to either construct a variant or expose a new way to display simple product prices.

wdyt?

@dylandepass dylandepass merged commit d54eb85 into main Dec 4, 2024
4 checks passed
@dylandepass dylandepass deleted the exclude-tables-on-simple branch December 4, 2024 19:17
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
## [1.7.2](v1.7.1...v1.7.2) (2024-12-04)

### Bug Fixes

* exclude tables if simple product ([#55](#55)) ([d54eb85](d54eb85))
Copy link

github-actions bot commented Dec 4, 2024

🎉 This PR is included in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants