Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added localisation support using placeholders for doc based authoring. #36

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Added localisation support using placeholders for doc based authoring. #36

wants to merge 5 commits into from

Conversation

ravise5
Copy link

@ravise5 ravise5 commented Apr 29, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix : https://github.com/adobe-rnd/form-block/issues/68

Test URLs:

What all is localised:

  1. Labels
  2. Descriptions or Help Text
  3. Placeholder text
  4. Error messages - OOTB messages were replaced with fixed strings via Replace OOTB browser messages with constant strings #17 and these are expected to be included in the placeholders sheet
  5. Fixed Strings of components (like drag and drop)

Customer would have to localise and include the constants strings maintained here in their placeholders sheet.

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 29, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 29, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/rae/localisation/form PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

ujjwal5
ujjwal5 reviewed May 10, 2024
View reviewed changes
blocks/form/form.js Show resolved Hide resolved
blocks/form/util.js Show resolved Hide resolved
@jalagari jalagari added the draft label Jul 26, 2024
nit23uec pushed a commit that referenced this pull request Aug 20, 2024
@buuhuu
feat: fragment block for crosswalk (#36)
4643b51 
* feat: add fragment def and model

* feat: add fragment def and model

* feat: preserve the fragment block, replace contents with fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepprakash345 deepprakash345 deepprakash345 left review comments

@ujjwal5 ujjwal5 ujjwal5 left review comments

@vdua vdua vdua left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ravise5 @vdua @ujjwal5 @deepprakash345 @jalagari