Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feast: adding exlude min and max #203

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feast: adding exlude min and max #203

wants to merge 1 commit into from

Conversation

pranay-tippa
Copy link

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

Copy link

aem-code-sync bot commented Nov 27, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

"component": "boolean",
"name": "excludeMaximumCheck",
"label": "Exclude maximum value",
"valueType": "boolean"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid adding these fields at this time since the current schema doesn't needs them. in cc they were added just for migration use cases. IMO, we should try to keep property sheet minimal and avoid clutterance until absolutely necessary

Copy link
Collaborator

@nit23uec nit23uec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use case?

@pranay-tippa pranay-tippa changed the title adding exlude min and max feast: adding exlude min and max Nov 29, 2024
@jalagari
Copy link

jalagari commented Dec 4, 2024

use case?

Only for feature priority with Core Component but for this need to work we need to include error message handling in block so postponing until we have customer

@pranay-tippa pranay-tippa marked this pull request as draft December 4, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants