UE: Bug Fixes #198
UE: Bug Fixes #198
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
| @@ -42,18 +43,19 @@ | |||
| "valueType": "boolean" | |||
| }, | |||
| { | |||
| "component": "number", | |||
| "component": "text", | |||
There was a problem hiding this comment.
is there a non numeric value should be entered here?
There was a problem hiding this comment.
There's a bug raised to the UE team not allowing placeholder text on number fields and maxOccur needed it indicating infinite reps. Since it would look inconsistent with maxOccur, I did this for alignment. The valueType is still number, we could add validations errors on non numeric inputs
There was a problem hiding this comment.
@TalmizAhmed - Did you open jira for bug? if not please create it and track
There was a problem hiding this comment.
We should not change the data type of persisted value just because of a placeholder. We can alternatively show some description in number field until the bug gets fixed. If required for customer we can persist text type on project basis but not in boilerplate
| @@ -11,7 +11,8 @@ | |||
| "jcr:title": "Panel", | |||
| "fieldType": "panel", | |||
| "enabled": true, | |||
| "visible": true | |||
| "visible": true, | |||
| "minOccur": 1 | |||
There was a problem hiding this comment.
we do support minOccur = 0 in authoring. is there something I'm missing?
There was a problem hiding this comment.
We had a discussion, and @jalagari preferred 1 default value in runtime even though 0 does show up in authoring
There was a problem hiding this comment.
is there a reason behind the same. Have we explored:
- the behaviour of core components
- any technical limitations with mic occur = 0 in the runtime?
There was a problem hiding this comment.
We have a limitation in runtime with min occur = 0.
When we have a button with a rule to add instance to a panel with minOccur = 0, it does not work.
FORMS-17543 has been logged for this issue.
There was a problem hiding this comment.
The default behaviour in core components when not having any numeric value defined the dialog is to render the panel once.
There was a problem hiding this comment.
In core components, do we persist minOccur = 1? If not, How is the panel rendered only once there?
| @@ -10,6 +10,14 @@ | |||
| "template": { | |||
| "jcr:title": "Drop Down List", | |||
| "fieldType": "drop-down", | |||
| "enum": [ | |||
There was a problem hiding this comment.
Can you please ensure this exists for radio, checkbox and also for wizard
| "regExp": "^[^$].*", | ||
| "customErrorMsg": "Name cannot start with $" | ||
| "regExp": "^(?!.*\\s)[^$].*", | ||
| "customErrorMsg": "Name cannot start with $ and cannot contain spaces" |
There was a problem hiding this comment.
Name can contain spaces as per the specification. We have supported it in the rule editor as well.
| @@ -11,7 +11,8 @@ | |||
| "jcr:title": "Text", | |||
| "fieldType": "plain-text", | |||
| "visible": true, | |||
| "textIsRich": true | |||
| "textIsRich": true, | |||
| "value": "Adaptive Form Text Component" | |||
There was a problem hiding this comment.
Rather than a value here, we should have css content via pseudo selectors as it's only a view issue
List of issues fixed:
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: