Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-14980 : Addng additional file attachment properties #193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lovelymandal16
Copy link

[Universal editor] [Component - File Attachment] Missing fields in the property dialog :
Button Text
Drag and Drop Text
Always show short description

Fix #FORMS-14980

Test URLs:
Before: https://main--aem-boilerplate-forms--adobe-rnd.hlx.live/
After: https://fileattachmentproperties--aem-boilerplate-forms--adobe-rnd.hlx.page/

Copy link

aem-code-sync bot commented Nov 7, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Nov 7, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@@ -50,6 +64,12 @@
"fields": [
{
"...": "./_common.json#/helpfields"
},
{
"component": "boolean",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should avoid adding always show short description functionality unless it's required by customers. and then we should add it for all components

Copy link
Collaborator

@nit23uec nit23uec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always show short desc should be avoided until sufficient no. of customer use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants