-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORMS-14980 : Addng additional file attachment properties #193
base: main
Are you sure you want to change the base?
Conversation
@@ -50,6 +64,12 @@ | |||
"fields": [ | |||
{ | |||
"...": "./_common.json#/helpfields" | |||
}, | |||
{ | |||
"component": "boolean", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should avoid adding always show short description functionality unless it's required by customers. and then we should add it for all components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always show short desc should be avoided until sufficient no. of customer use cases
[Universal editor] [Component - File Attachment] Missing fields in the property dialog :
Button Text
Drag and Drop Text
Always show short description
Fix #FORMS-14980
Test URLs:
Before: https://main--aem-boilerplate-forms--adobe-rnd.hlx.live/
After: https://fileattachmentproperties--aem-boilerplate-forms--adobe-rnd.hlx.page/