FORMS-14814: allow multiple file attachment #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
…orms into multiplefileupload
|
@lovelymandal16 Could you refactor the changes to align with the new boilerplate structure? |
nit23uec
reviewed
Nov 28, 2024
nit23uec
requested changes
Nov 28, 2024
nit23uec
reviewed
Dec 10, 2024
| @@ -74,6 +81,30 @@ | |||
| "name": "acceptMessage", | |||
| "label": "File type error message", | |||
| "valueType": "string" | |||
| }, | |||
There was a problem hiding this comment.
These fields should only come if multiple is true
nit23uec
reviewed
Dec 10, 2024
| @@ -211,15 +211,26 @@ | |||
| } | |||
| }, | |||
| { | |||
| "title": "Captcha (Invisible)", | |||
| "id": "captcha", | |||
| "title": "Checkbox group", | |||
There was a problem hiding this comment.
Any reason for these changes?
nit23uec
reviewed
Dec 10, 2024
| if (input.multiple) { | ||
| field.type = 'file[]'; | ||
| if (field.properties?.maxFilesMessage) { | ||
| input.dataset.maxFilesMessage = field.properties.maxFilesMessage; |
There was a problem hiding this comment.
It should come in constraints msgs and not as custom props.
nit23uec
reviewed
Dec 10, 2024
blocks/form/form.js
Outdated
| @@ -303,7 +303,7 @@ function inputDecorator(field, element) { | |||
| input.checked = field.value === input.value; | |||
| } | |||
| } else { | |||
| input.multiple = field.type === 'file[]'; | |||
| input.multiple = field.type === 'file[]' || field.properties?.allowMultiple; | |||
There was a problem hiding this comment.
Allow multiple check should not be required here. It should be handled via sling models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: