Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Telephone as a OOTB decorated component with type tel #172

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Telephone as a OOTB decorated component with type tel #172

wants to merge 3 commits into from

Conversation

TalmizAhmed
Copy link

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Sep 18, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Sep 18, 2024 •
edited
Loading

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TalmizAhmed TalmizAhmed changed the title Telephone as a OOTB decorated component with type tel feat: Telephone as a OOTB decorated component with type tel Sep 18, 2024
nit23uec
nit23uec requested changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@nit23uec nit23uec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, pls implement it as OOTB component

@nit23uec
Copy link
Collaborator

this won't work until the cc is released

@TalmizAhmed TalmizAhmed requested a review from nit23uec October 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nit23uec nit23uec Awaiting requested review from nit23uec

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalmizAhmed @nit23uec