Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urlencode #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix urlencode #27

wants to merge 1 commit into from

Conversation

zrq495
Copy link

@zrq495 zrq495 commented Jun 21, 2019

When the value has been urlencoded, it needs to be urlencoded again, not just replacing &.

@zrq495 zrq495 changed the title fixes urlencode Fix urlencode Jun 21, 2019
@ddragosd
Copy link
Member

Thanks @zrq495 ! Can you also add a test for this case ?

@fbergero
Copy link

@zrq495 any updates on this? I need this fix ❤️

@zrq495
Copy link
Author

zrq495 commented Sep 22, 2020

@ddascal @fbergero I am sorry. I had been trying to run the test, but i failed to make it.
I have been using it under my production and it proves to be accessible, so you can use it directly.
if it is convenient for you, you can add a test for this case.

@fbergero
Copy link

fbergero commented Sep 22, 2020

@zrq495 is your build uploaded to luarocks?
Additionally this also escapes the topic ARN like

arn%3Aaws%3Asns%3Aus-east-1%3AXXXXXX%3Asometopic

That doesn't make a difference?

@zrq495
Copy link
Author

zrq495 commented Sep 23, 2020

@fbergero Just build locally
I didn't notice ARN, does it not work properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants