Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lipidomics to data type #120

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add lipidomics to data type #120

wants to merge 8 commits into from

Conversation

ameliakallaher
Copy link
Contributor

Add data type value for AGMP

Copy link

github-actions bot commented Oct 4, 2024

Test Suite Report

Template Generation

The following manifest templates had at least one dependency with
changes detected:

template result link
FileAnnotationTemplate template link

🚧 Manifest Validation - COMING SOON

Copy link

github-actions bot commented Oct 4, 2024

Test Suite Report

Template Generation

The following manifest templates had at least one dependency with
changes detected:

template result link
BiospecimenInvitroMetadataTemplate template link
BiospecimenMetadataTemplate template link
FileAnnotationTemplate template link
IndividualAnimalMODEL-ADMetadataTemplate template link

🚧 Manifest Validation - COMING SOON

@avanlinden
Copy link
Contributor

@ameliakallaher I know that the answer is "Duke", but do you think we really need a separate data type for lipidomics when we have dataType = metabolomics + metaboliteType = lipids? Lipidomics is just a subset of metabolomics and we try to keep the data types broad enough that they are a useful partition for discoverability in the portal. The "assay" key tends to be more specific.

I wonder if we can talk to other DCCs at Sage to see if they make a distinction between metabolomics and lipidomics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants