Skip to content

Commit

Permalink
Google Maps Addition for various validations for addresses
Browse files Browse the repository at this point in the history
  • Loading branch information
@adityaduggal
adityaduggal committed Jun 27, 2020
1 parent 64770b3 commit 3a50ae7
Show file tree
Hide file tree
Showing 4 changed files with 175 additions and 150 deletions.
5 changes: 5 additions & 0 deletions rigpl_erpnext/rigpl_erpnext/doctype/carrier_tracking/carrier_tracking.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from ...validations.sales_invoice import create_new_carrier_track
from .fedex_functions import shipment_booking, start_delete_shipment, get_signature_proof, \
validate_address, get_rates_from_fedex, get_available_services
from ....utils.sales_utils import validate_address_google_update


class CarrierTracking(WebsiteGenerator):
Expand Down Expand Up @@ -42,6 +43,10 @@ def autoname(self):
self.validate()

def validate(self):
if self.to_address:
validate_address_google_update(self.to_address)
if self.from_address:
validate_address_google_update(self.from_address)
if self.docstatus != 1:
self.published = 0
self.route = ""
Expand Down
73 changes: 38 additions & 35 deletions rigpl_erpnext/rigpl_erpnext/validations/quotation.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,40 +2,43 @@
from __future__ import unicode_literals
import frappe
from frappe import msgprint
from rigpl_erpnext.utils.sales_utils import \
check_get_pl_rate, get_hsn_code, check_taxes_integrity, check_dynamic_link
from ...utils.sales_utils import check_get_pl_rate, get_hsn_code, check_taxes_integrity, check_dynamic_link, \
validate_address_google_update

def validate(doc,method):
if doc.quotation_to == 'Customer':
check_dynamic_link(parenttype="Address", parent=doc.customer_address, \
link_doctype="Customer", link_name=doc.party_name)
check_dynamic_link(parenttype="Address", parent=doc.shipping_address_name, \
link_doctype="Customer", link_name=doc.party_name)
check_dynamic_link(parenttype="Contact", parent=doc.contact_person, \
link_doctype="Customer", link_name=doc.party_name)
else:
if doc.customer_address:
check_dynamic_link(parenttype="Address", parent=doc.customer_address, \
link_doctype="Lead", link_name=doc.party_name)
if doc.shipping_address_name:
check_dynamic_link(parenttype="Address", parent=doc.shipping_address_name, \
link_doctype="Lead", link_name=doc.party_name)

check_taxes_integrity(doc)
for rows in doc.items:
if not rows.price_list:
rows.price_list = doc.selling_price_list
get_hsn_code(rows)
check_get_pl_rate(doc, rows)
#Check if Lead is Converted or Not, if the lead is converted
#then don't allow it to be selected without linked customer
if doc.quotation_to == "Lead":
link = frappe.db.sql("""SELECT name FROM `tabCustomer`
WHERE lead_name = '%s'"""%(doc.party_name), as_list=1)
if link:
frappe.throw(("Lead {0} is Linked to Customer {1} so kindly make quotation for \
Customer and not Lead").format(doc.party_name, link[0][0]))
#below code updates the CETSH number for the item in Quotation and updates letter head
letter_head_tax = frappe.db.get_value("Sales Taxes and Charges Template", \
doc.taxes_and_charges, "letter_head")
doc.letter_head = letter_head_tax
def validate(doc, method):
validate_address_google_update(doc.customer_address)
validate_address_google_update(doc.shipping_address_name)
if doc.quotation_to == 'Customer':
check_dynamic_link(parenttype="Address", parent=doc.customer_address,
link_doctype="Customer", link_name=doc.party_name)
check_dynamic_link(parenttype="Address", parent=doc.shipping_address_name,
link_doctype="Customer", link_name=doc.party_name)
check_dynamic_link(parenttype="Contact", parent=doc.contact_person,
link_doctype="Customer", link_name=doc.party_name)
else:
if doc.customer_address:
check_dynamic_link(parenttype="Address", parent=doc.customer_address,
link_doctype="Lead", link_name=doc.party_name)
if doc.shipping_address_name:
check_dynamic_link(parenttype="Address", parent=doc.shipping_address_name,
link_doctype="Lead", link_name=doc.party_name)

check_taxes_integrity(doc)
for rows in doc.items:
if not rows.price_list:
rows.price_list = doc.selling_price_list
get_hsn_code(rows)
check_get_pl_rate(doc, rows)
# Check if Lead is Converted or Not, if the lead is converted
# then don't allow it to be selected without linked customer
if doc.quotation_to == "Lead":
link = frappe.db.sql("""SELECT name FROM `tabCustomer`
WHERE lead_name = '%s'""" % (doc.party_name), as_list=1)
if link:
frappe.throw(("Lead {0} is Linked to Customer {1} so kindly make quotation for \
Customer and not Lead").format(doc.party_name, link[0][0]))
# below code updates the CETSH number for the item in Quotation and updates letter head
letter_head_tax = frappe.db.get_value("Sales Taxes and Charges Template",
doc.taxes_and_charges, "letter_head")
doc.letter_head = letter_head_tax
2 changes: 2 additions & 0 deletions rigpl_erpnext/rigpl_erpnext/validations/sales_order.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@


def validate(doc, method):
validate_address_google_update(doc.customer_address)
validate_address_google_update(doc.shipping_address_name)
check_dynamic_link(parenttype="Address", parent=doc.customer_address,
link_doctype="Customer", link_name=doc.customer)
check_dynamic_link(parenttype="Address", parent=doc.shipping_address_name,
Expand Down
245 changes: 130 additions & 115 deletions rigpl_erpnext/utils/sales_utils.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,129 +3,144 @@
import frappe
from frappe.utils import flt


def validate_address_google_update(add_doc_name):
add_doc = frappe.get_doc('Address', add_doc_name)
if not add_doc.json_reply and add_doc.dont_update_from_google != 1:
frappe.throw('Address {} is Not Updated from Google, Please Open and Save '
'the Address once'.format(add_doc.name))


def copy_address_and_check(document):
if document.doctype == 'Delivery Note':
so_field = "against_sales_order"
elif document.doctype == 'Sales Invoice':
so_field = 'sales_order'
for items in document.items:
if items.get(so_field):
so_doc = frappe.get_doc("Sales Order", items.get(so_field))
if document.customer_address != so_doc.customer_address:
frappe.throw("Customer Address mentioned in {} {} does not match \
with Customer Address of SO# {} mentioned in Row# {}".\
format(document.doctype, document.name, items.get(so_field), \
items.idx))
if document.shipping_address_name != so_doc.shipping_address_name:
frappe.throw("Shipping Address mentioned in {} {} does not match \
with Shipping Address of SO# {} mentioned in Row# {}".\
format(document.doctype, document.name, items.get(so_field), \
items.idx))
if document.doctype == 'Delivery Note':
so_field = "against_sales_order"
elif document.doctype == 'Sales Invoice':
so_field = 'sales_order'
for items in document.items:
if items.get(so_field):
so_doc = frappe.get_doc("Sales Order", items.get(so_field))
if document.customer_address != so_doc.customer_address:
frappe.throw("Customer Address mentioned in {} {} does not match \
with Customer Address of SO# {} mentioned in Row# {}". \
format(document.doctype, document.name, items.get(so_field), \
items.idx))
if document.shipping_address_name != so_doc.shipping_address_name:
frappe.throw("Shipping Address mentioned in {} {} does not match \
with Shipping Address of SO# {} mentioned in Row# {}". \
format(document.doctype, document.name, items.get(so_field), \
items.idx))


def check_strict_po_rules(document):
cust_doc = frappe.get_doc("Customer", document.customer)
if cust_doc.follow_strict_po_rules == 1:
so_list = []
if document.doctype == 'Delivery Note':
so_field = "against_sales_order"
elif document.doctype == 'Sales Invoice':
so_field = 'sales_order'
for it in document.items:
if it.get(so_field):
if it.idx == 1:
so_list.append(it.get(so_field))
if it.idx > 1:
if it.get(so_field) not in so_list:
frappe.throw("Customer {} Follows Strict PO Rules hence \
Row {} is Rejected. Make new {} for SO# {}".\
format(document.customer, it.idx, document.doctype, it.get(so_field)))
cust_doc = frappe.get_doc("Customer", document.customer)
if cust_doc.follow_strict_po_rules == 1:
so_list = []
if document.doctype == 'Delivery Note':
so_field = "against_sales_order"
elif document.doctype == 'Sales Invoice':
so_field = 'sales_order'
for it in document.items:
if it.get(so_field):
if it.idx == 1:
so_list.append(it.get(so_field))
if it.idx > 1:
if it.get(so_field) not in so_list:
frappe.throw("Customer {} Follows Strict PO Rules hence \
Row {} is Rejected. Make new {} for SO# {}". \
format(document.customer, it.idx, document.doctype, it.get(so_field)))


def get_hsn_code(row_dict):
custom_tariff = frappe.db.get_value("Item", row_dict.item_code, "customs_tariff_number")
if custom_tariff:
if len(custom_tariff) == 8:
row_dict.gst_hsn_code = custom_tariff
else:
frappe.throw(("Item Code {0} in line# {1} has a Custom Tariff {2} which not \
8 digit, please get the Custom Tariff corrected").\
format(row_dict.item_code, row_dict.idx, custom_tariff))
else:
frappe.throw(("Item Code {0} in line# {1} does not have linked Customs \
Tariff in Item Master").format(row_dict.item_code, row_dict.idx))
custom_tariff = frappe.db.get_value("Item", row_dict.item_code, "customs_tariff_number")
if custom_tariff:
if len(custom_tariff) == 8:
row_dict.gst_hsn_code = custom_tariff
else:
frappe.throw(("Item Code {0} in line# {1} has a Custom Tariff {2} which not \
8 digit, please get the Custom Tariff corrected"). \
format(row_dict.item_code, row_dict.idx, custom_tariff))
else:
frappe.throw(("Item Code {0} in line# {1} does not have linked Customs \
Tariff in Item Master").format(row_dict.item_code, row_dict.idx))


def check_get_pl_rate(document, row_dict):
pl_doc = frappe.get_doc("Price List", row_dict.price_list)
if pl_doc.disable_so == 1:
frappe.throw("Sales Order Booking Disabled for {} at Row# {}".\
format(row_dict.price_list, row_dict.idx))
item_pl_rate = frappe.db.sql("""SELECT price_list_rate, currency FROM `tabItem Price`
WHERE price_list = '%s' AND item_code = '%s'
AND selling = 1"""%(row_dict.price_list, row_dict.item_code), as_dict=1)

if item_pl_rate:
if row_dict.price_list_rate != item_pl_rate[0].price_list_rate \
and document.currency == item_pl_rate[0].currency:
row_dict.price_list_rate = item_pl_rate[0].price_list_rate
else:
frappe.msgprint("In {}# {} at Row# {} and Item Code: {} Price List \
Rate is Not Defined".format(document.doctype, document.name, row_dict.idx, \
row_dict.item_code))
pl_doc = frappe.get_doc("Price List", row_dict.price_list)
if pl_doc.disable_so == 1:
frappe.throw("Sales Order Booking Disabled for {} at Row# {}". \
format(row_dict.price_list, row_dict.idx))
item_pl_rate = frappe.db.sql("""SELECT price_list_rate, currency FROM `tabItem Price`
WHERE price_list = '%s' AND item_code = '%s'
AND selling = 1""" % (row_dict.price_list, row_dict.item_code), as_dict=1)

if item_pl_rate:
if row_dict.price_list_rate != item_pl_rate[0].price_list_rate \
and document.currency == item_pl_rate[0].currency:
row_dict.price_list_rate = item_pl_rate[0].price_list_rate
else:
frappe.msgprint("In {}# {} at Row# {} and Item Code: {} Price List \
Rate is Not Defined".format(document.doctype, document.name, row_dict.idx, \
row_dict.item_code))


def check_dynamic_link(parenttype, parent, link_doctype, link_name):
link_type = frappe.db.sql("""SELECT name FROM `tabDynamic Link`
WHERE docstatus = 0 AND parenttype = '%s' AND parent = '%s'
AND link_doctype = '%s' AND link_name = '%s'"""%(parenttype, parent, \
link_doctype, link_name), as_list=1)
if not link_type:
frappe.throw("{} {} does not belong to {} {}".\
format(parenttype, parent, link_doctype, link_name))
link_type = frappe.db.sql("""SELECT name FROM `tabDynamic Link`
WHERE docstatus = 0 AND parenttype = '%s' AND parent = '%s'
AND link_doctype = '%s' AND link_name = '%s'""" % (parenttype, parent, \
link_doctype, link_name), as_list=1)
if not link_type:
frappe.throw("{} {} does not belong to {} {}". \
format(parenttype, parent, link_doctype, link_name))


def check_taxes_integrity(document):
template = frappe.get_doc("Sales Taxes and Charges Template", document.taxes_and_charges)
if len(template.taxes) != len(document.taxes):
frappe.throw(("Tax Template {} Data does not match with Document# {}'s Tax \
{}").format(template.name, document.name, document.taxes_and_charges))
for tax in document.taxes:
for temp in template.taxes:
if tax.idx == temp.idx:
if tax.charge_type != temp.charge_type or tax.row_id != temp.row_id or \
tax.account_head != temp.account_head or tax.included_in_print_rate \
!= temp.included_in_print_rate or tax.rate != temp.rate:
frappe.throw(("Selected Tax {0}'s table does not match with tax table \
of Sales Order# {1}. Check Row # {2} or reload Taxes").\
format(document.taxes_and_charges, document.name, tax.idx))

def check_gst_rules(bill_add_name,ship_add_name, taxes_name, naming_series, name, series=None):
bill_add_doc = frappe.get_doc("Address", bill_add_name)
ship_add_doc = frappe.get_doc("Address", ship_add_name)
template_doc = frappe.get_doc("Sales Taxes and Charges Template", taxes_name)
series = flt(series)

bill_state = bill_add_doc.state_rigpl
bill_country = bill_add_doc.country
series_template = template_doc.series

#Check series of Tax with the Series Selected for Invoice
if series_template != naming_series[int(series):int(series+2)] and series_template != name[int(series):int(series+2)]:
frappe.throw(("Selected Tax Template {0} Not Allowed since Series Selected {1} and \
Document# {2} don't match with the Selected Template").format( \
taxes_name, naming_series, name))

if taxes_name != 'OGL':
#Check if Shipping State is Same as Template State then check if the tax template is LOCAL
#Else if the States are different then the template should NOT BE LOCAL
if bill_state == template_doc.state and template_doc.is_export != 1:
if template_doc.is_local_sales != 1:
frappe.throw(("Selected Tax {0} is NOT LOCAL Tax but Shipping Address is \
in Same State {1}, hence either change Shipping Address or Change the \
Selected Tax").format(taxes_name, bill_state))
elif bill_country == 'India' and bill_state != template_doc.state:
if template_doc.is_local_sales == 1:
frappe.throw(("Selected Tax {0} is LOCAL Tax but Shipping Address is \
in Different State {1}, hence either change Shipping Address or Change the \
Selected Tax").format(taxes_name, bill_state))
elif bill_country != 'India': #Case of EXPORTS
if template_doc.state is not None and template_doc.is_export != 1:
frappe.throw(("Selected Tax {0} is for Indian Sales but Shipping Address is \
in Different Country {1}, hence either change Shipping Address or Change the \
Selected Tax").format(taxes_name, bill_country))
template = frappe.get_doc("Sales Taxes and Charges Template", document.taxes_and_charges)
if len(template.taxes) != len(document.taxes):
frappe.throw(("Tax Template {} Data does not match with Document# {}'s Tax \
{}").format(template.name, document.name, document.taxes_and_charges))
for tax in document.taxes:
for temp in template.taxes:
if tax.idx == temp.idx:
if tax.charge_type != temp.charge_type or tax.row_id != temp.row_id or \
tax.account_head != temp.account_head or tax.included_in_print_rate \
!= temp.included_in_print_rate or tax.rate != temp.rate:
frappe.throw(("Selected Tax {0}'s table does not match with tax table \
of Sales Order# {1}. Check Row # {2} or reload Taxes"). \
format(document.taxes_and_charges, document.name, tax.idx))


def check_gst_rules(bill_add_name, ship_add_name, taxes_name, naming_series, name, series=None):
bill_add_doc = frappe.get_doc("Address", bill_add_name)
ship_add_doc = frappe.get_doc("Address", ship_add_name)
template_doc = frappe.get_doc("Sales Taxes and Charges Template", taxes_name)
series = flt(series)

bill_state = bill_add_doc.state_rigpl
bill_country = bill_add_doc.country
series_template = template_doc.series

# Check series of Tax with the Series Selected for Invoice
if series_template != naming_series[int(series):int(series + 2)] and series_template != name[int(series):int(
series + 2)]:
frappe.throw(("Selected Tax Template {0} Not Allowed since Series Selected {1} and \
Document# {2} don't match with the Selected Template").format( \
taxes_name, naming_series, name))

if taxes_name != 'OGL':
# Check if Shipping State is Same as Template State then check if the tax template is LOCAL
# Else if the States are different then the template should NOT BE LOCAL
if bill_state == template_doc.state and template_doc.is_export != 1:
if template_doc.is_local_sales != 1:
frappe.throw(("Selected Tax {0} is NOT LOCAL Tax but Shipping Address is \
in Same State {1}, hence either change Shipping Address or Change the \
Selected Tax").format(taxes_name, bill_state))
elif bill_country == 'India' and bill_state != template_doc.state:
if template_doc.is_local_sales == 1:
frappe.throw(("Selected Tax {0} is LOCAL Tax but Shipping Address is \
in Different State {1}, hence either change Shipping Address or Change the \
Selected Tax").format(taxes_name, bill_state))
elif bill_country != 'India': # Case of EXPORTS
if template_doc.state is not None and template_doc.is_export != 1:
frappe.throw(("Selected Tax {0} is for Indian Sales but Shipping Address is \
in Different Country {1}, hence either change Shipping Address or Change the \
Selected Tax").format(taxes_name, bill_country))

0 comments on commit 3a50ae7

Please sign in to comment.