Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run_command log error before raising #87

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

rhizoome
Copy link

No description provided.

@rhizoome rhizoome requested review from winged and Melkor333 March 13, 2024 17:40
@rhizoome rhizoome force-pushed the jlf/feat-run_command-log-error-before-raising branch 3 times, most recently from 8db94a8 to 212db3b Compare March 13, 2024 18:45
@rhizoome rhizoome force-pushed the jlf/feat-run_command-log-error-before-raising branch 2 times, most recently from 66d6908 to eebeb89 Compare March 13, 2024 18:51
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@winged winged merged commit 0abda42 into main Mar 14, 2024
1 check passed
@rhizoome rhizoome deleted the jlf/feat-run_command-log-error-before-raising branch March 21, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants