Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Keycloak to v26.0.7 #1348

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

open-dynaMIX
Copy link
Member

Description

Update Keycloak to v26.0.7.

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

pre-commit

Running the pre-commit hooks changed a lot of unrelated files.

@open-dynaMIX open-dynaMIX requested review from hairmare, eyenx and a team as code owners December 11, 2024 10:52
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 11, 2024
name: example
spec:
arn: <some-pca-arn>
{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the snapshot updater did an upsi wupsi... please revert all changes that aren't in the keycloak-operator chart

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@open-dynaMIX open-dynaMIX force-pushed the update_keycloak_26.0.7 branch from d2a94eb to 2dc4274 Compare December 11, 2024 10:59
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2024
@fugal-dy fugal-dy requested a review from hairmare December 11, 2024 11:10
@@ -16,7 +16,7 @@ maintainers:
annotations:
artifacthub.io/changes: |
- kind: changed
description: "chore: update keycloak from v26.0.1 to v26.0.6"
description: "chore: update keycloak to v26.0.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "chore: update keycloak to v26.0.7"
description: "chore: update keycloak from v26.0.6 to v26.0.7"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -16,7 +16,7 @@ maintainers:
annotations:
artifacthub.io/changes: |
- kind: changed
description: "chore: update keycloak from v26.0.1 to v26.0.6"
description: "chore: update keycloak to v26.0.7"
links:
- name: "Keycloak 26.0.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the old links need removing... artifacthub aggregates the releasenotes over time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed all but the last (a379e94). that what you meant?

@fugal-dy fugal-dy requested a review from hairmare December 11, 2024 16:21
Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fugal-dy fugal-dy merged commit 22367ae into adfinis:main Dec 11, 2024
3 checks passed
@open-dynaMIX open-dynaMIX deleted the update_keycloak_26.0.7 branch December 12, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants