Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add awspca issuers #1333

Merged
merged 10 commits into from
Nov 11, 2024
Merged

feat: add awspca issuers #1333

merged 10 commits into from
Nov 11, 2024

Conversation

sule26
Copy link
Contributor

@sule26 sule26 commented Nov 3, 2024

Description

This PR enables the configuration of AWSPCAClusterIssuer and AWSPCAIssuer resources. With this implementation, it will be possible to configure certificate issuers directly integrated with AWS Private Certificate Authority (AWS PCA)

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2024
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2024
@sule26 sule26 marked this pull request as ready for review November 3, 2024 16:12
@sule26 sule26 requested review from hairmare and a team as code owners November 3, 2024 16:12
@sule26 sule26 requested a review from gianklug November 3, 2024 16:12
charts/cert-manager-issuers/Chart.yaml Outdated Show resolved Hide resolved
@eyenx
Copy link
Member

eyenx commented Nov 3, 2024

Another question: How are the CRDs deployed? I guess these re no CRD that are deployed with the cert manager Helm Chart by default?

@eyenx
Copy link
Member

eyenx commented Nov 3, 2024

Another question: How are the CRDs deployed? I guess these re no CRD that are deployed with the cert manager Helm Chart by default?

I guess I anwered this myself: in a separate chart:

https://github.com/cert-manager/aws-privateca-issuer

@sule26
Copy link
Contributor Author

sule26 commented Nov 3, 2024

@eyenx So is everything ok?

@eyenx
Copy link
Member

eyenx commented Nov 3, 2024

@sule26 could you please add a mention of the deployed issuers in NOTES.txt of the chart? Thanks.

The rest LGTM. Any objections @hairmare ?

@sule26
Copy link
Contributor Author

sule26 commented Nov 3, 2024

@eyenx Done!

Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@eyenx eyenx self-requested a review November 4, 2024 06:22
Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tthe CI Is failing :/ @sule26

@sule26
Copy link
Contributor Author

sule26 commented Nov 4, 2024

@eyenx Weird! I haven't changed anything except NOTES.txt. Reading the logs It seems to be something reletaded with the common chart. I'll take a look as soon as I can.

@sule26
Copy link
Contributor Author

sule26 commented Nov 6, 2024

@eyenx Could the pipeline be run again? After spending some time running the pre-commit checks on my machine, I didn’t encounter any errors. From what I can see in the logs, there’s an issue related to the common chart.

Logs from the pipeline:

+ helm dep build charts/cert-manager-issuers
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "adfinis" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading common from repo https://charts.adfinis.com/
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804 for moving: stat charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804: no such file or directory (Skipping)
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148 for moving: file 'charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148' does not appear to be a gzipped archive; got 'application/octet-stream' (Skipping)
Deleting outdated charts

I’m open to any ideas for resolving this, and having this PR accepted quickly would really help me out. Thanks!

@eyenx
Copy link
Member

eyenx commented Nov 7, 2024

@eyenx Could the pipeline be run again? After spending some time running the pre-commit checks on my machine, I didn’t encounter any errors. From what I can see in the logs, there’s an issue related to the common chart.

Logs from the pipeline:

+ helm dep build charts/cert-manager-issuers
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "adfinis" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading common from repo https://charts.adfinis.com/
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804 for moving: stat charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804: no such file or directory (Skipping)
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148 for moving: file 'charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148' does not appear to be a gzipped archive; got 'application/octet-stream' (Skipping)
Deleting outdated charts

I’m open to any ideas for resolving this, and having this PR accepted quickly would really help me out. Thanks!

Let me check this out today

@sule26 sule26 requested a review from eyenx November 9, 2024 21:42
@eyenx
Copy link
Member

eyenx commented Nov 11, 2024

@eyenx Could the pipeline be run again? After spending some time running the pre-commit checks on my machine, I didn’t encounter any errors. From what I can see in the logs, there’s an issue related to the common chart.
Logs from the pipeline:

+ helm dep build charts/cert-manager-issuers
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "adfinis" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading common from repo https://charts.adfinis.com/
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804 for moving: stat charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804: no such file or directory (Skipping)
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148 for moving: file 'charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148' does not appear to be a gzipped archive; got 'application/octet-stream' (Skipping)
Deleting outdated charts

I’m open to any ideas for resolving this, and having this PR accepted quickly would really help me out. Thanks!

Let me check this out today

#1335 seems to have fixed the CI

Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sule26 thank you for your contribution!

@eyenx eyenx merged commit 95215e2 into adfinis:main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants