-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add awspca issuers #1333
feat: add awspca issuers #1333
Conversation
Another question: How are the CRDs deployed? I guess these re no CRD that are deployed with the cert manager Helm Chart by default? |
I guess I anwered this myself: in a separate chart: |
@eyenx So is everything ok? |
@eyenx Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tthe CI Is failing :/ @sule26
@eyenx Weird! I haven't changed anything except NOTES.txt. Reading the logs It seems to be something reletaded with the common chart. I'll take a look as soon as I can. |
@eyenx Could the pipeline be run again? After spending some time running the pre-commit checks on my machine, I didn’t encounter any errors. From what I can see in the logs, there’s an issue related to the common chart. Logs from the pipeline: + helm dep build charts/cert-manager-issuers
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "adfinis" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading common from repo https://charts.adfinis.com/
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804 for moving: stat charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz2216016804: no such file or directory (Skipping)
Could not verify charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148 for moving: file 'charts/cert-manager-issuers/tmpcharts/common-0.0.7.tgz3565449148' does not appear to be a gzipped archive; got 'application/octet-stream' (Skipping)
Deleting outdated charts I’m open to any ideas for resolving this, and having this PR accepted quickly would really help me out. Thanks! |
Let me check this out today |
#1335 seems to have fixed the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sule26 thank you for your contribution!
Description
This PR enables the configuration of AWSPCAClusterIssuer and AWSPCAIssuer resources. With this implementation, it will be possible to configure certificate issuers directly integrated with AWS Private Certificate Authority (AWS PCA)
Issues
Checklist
artifacthub.io/changes
annotation inChart.yaml
, check the example in the documentation.pre-commit run
docs/