Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging-apps): update helm-charts #1281

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

maxthier
Copy link
Contributor

Description

This PR updates the helm-charts in the logging-apps chart.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@maxthier maxthier requested a review from a team as a code owner June 21, 2024 09:36
@maxthier maxthier requested review from tongpu and vmaillot June 21, 2024 09:36
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 21, 2024
@maxthier
Copy link
Contributor Author

Where can we test changes like fluentd? Also somehow we havent updated fluentd since 2023-03-18.

@tongpu
Copy link
Member

tongpu commented Jun 21, 2024

Where can we test changes like fluentd? Also somehow we havent updated fluentd since 2023-03-18.

I'm honestly think we're not using fluentd at any customers anymore.

@hairmare
Copy link
Contributor

Where can we test changes like fluentd? Also somehow we havent updated fluentd since 2023-03-18.

I'm honestly think we're not using fluentd at any customers anymore.

yeah, it should be replaced with fluentbit at this point... we should follow up with deprecating this in the chart after this PR

@maxthier maxthier enabled auto-merge (squash) June 26, 2024 09:48
@maxthier maxthier disabled auto-merge June 26, 2024 09:55
@maxthier maxthier enabled auto-merge (squash) June 26, 2024 09:59
@maxthier maxthier merged commit 52cca50 into main Jun 26, 2024
3 checks passed
@maxthier maxthier deleted the chore/update_logging_apps branch June 26, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants