Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(azure-apps): update charts #1280

Merged
merged 2 commits into from
Jun 26, 2024
Merged

chore(azure-apps): update charts #1280

merged 2 commits into from
Jun 26, 2024

Conversation

maxthier
Copy link
Contributor

Description

This PR updates the helm-charts in the azure-apps chart.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@maxthier maxthier requested a review from a team as a code owner June 21, 2024 09:06
@maxthier maxthier requested review from eyenx and gianklug June 21, 2024 09:06
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 21, 2024
@maxthier
Copy link
Contributor Author

How can we test this? I'm mainly worried about azure-workload-identity-webhook because it gets upgraded from 0.12 to 1.3

@hairmare
Copy link
Contributor

afair it would be needed for cases like having gitlab runners use workload identities

@maxthier maxthier enabled auto-merge (squash) June 26, 2024 09:49
@maxthier maxthier merged commit d9a4413 into main Jun 26, 2024
3 checks passed
@maxthier maxthier deleted the chore/update_azure_apps branch June 26, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare approved these changes

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner automatically assigned from adfinis/helm-charts

@gianklug gianklug Awaiting requested review from gianklug gianklug is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxthier @hairmare