-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include optional namespace in keycloak-operator templates #1274
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -3,6 +3,9 @@ apiVersion: rbac.authorization.k8s.io/v1 | |||||||
kind: ClusterRole | ||||||||
metadata: | ||||||||
name: keycloakcontroller-cluster-role | ||||||||
{{- with .Values.operator.namespace }} | ||||||||
namespace: {{ . }} | ||||||||
{{- end }} | ||||||||
labels: | ||||||||
{{- include "keycloak-operator.operator.labels" . | nindent 4 }} | ||||||||
rules: | ||||||||
|
@@ -25,6 +28,9 @@ apiVersion: rbac.authorization.k8s.io/v1 | |||||||
kind: ClusterRole | ||||||||
metadata: | ||||||||
name: keycloakrealmimportcontroller-cluster-role | ||||||||
{{- with .Values.operator.namespace }} | ||||||||
namespace: {{ . }} | ||||||||
{{- end }} | ||||||||
Comment on lines
+31
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ClusterRoles are not namespaced, so this is not required here.
Suggested change
|
||||||||
labels: | ||||||||
{{- include "keycloak-operator.operator.labels" . | nindent 4 }} | ||||||||
rules: | ||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ apiVersion: apps/v1 | |
kind: Deployment | ||
metadata: | ||
name: {{ include "keycloak-operator.operator.fullname" . }} | ||
{{- with .Values.operator.namespace }} | ||
namespace: {{ . }} | ||
{{- end }} | ||
Comment on lines
+6
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it also required that you can deploy the operator in another namespace the the one the Helm chart is being deployed into? |
||
labels: | ||
{{- include "keycloak-operator.operator.labels" . | nindent 4 }} | ||
spec: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ClusterRoles are not namespaced, so this is not required here.