Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(openshift-etcd-backup): update openshift-etcd-backup image to v1.7.0 #1162

Merged
merged 1 commit into from
Dec 13, 2023
Merged

chore(openshift-etcd-backup): update openshift-etcd-backup image to v1.7.0 #1162

merged 1 commit into from
Dec 13, 2023

Conversation

tongpu
Copy link
Member

@tongpu tongpu commented Dec 12, 2023 •
edited by hairmare
Loading

Description

Update openshift-etcd-backup image to v1.7.0, switches base image to ubi9-minimal

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2023
hairmare
hairmare approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the LGTMest of LGTMs

LGTM

@hairmare hairmare marked this pull request as ready for review December 12, 2023 20:38
@hairmare hairmare requested a review from a team as a code owner December 12, 2023 20:38
@hairmare hairmare requested review from eyenx and gianklug December 12, 2023 20:38
@hairmare
Copy link
Contributor

marked it as ready for ya because

EL9 ALL THE THINGS meme

@tongpu tongpu merged commit 6233f2d into adfinis:main Dec 13, 2023
3 checks passed
@tongpu tongpu deleted the chore/update_openshift-etcd-backup_image_1.7.0 branch December 13, 2023 07:26
@tongpu
Copy link
Member Author

tongpu commented Dec 13, 2023

Some people bring their kids to bed when they come home and spend the rest of the day watching MtG videos on YouTube, but there's always that one vigilante that review PRs not even marked as ready yet. :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare approved these changes

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner automatically assigned from adfinis/helm-charts

@gianklug gianklug Awaiting requested review from gianklug gianklug is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tongpu @hairmare