Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc-apps): update KEDA chart from 2.10.1 to 2.12.0 #1132

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

maxthier
Copy link
Contributor

@maxthier maxthier commented Oct 9, 2023

Description

Update KEDA from 2.10.1 to 2.12.0. There are some new features including new Scalers.

Issues

Fixes #1122

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@maxthier maxthier requested a review from a team as a code owner October 9, 2023 14:56
@maxthier maxthier requested review from hairmare and vmaillot October 9, 2023 14:56
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2023
vmaillot
vmaillot previously approved these changes Oct 9, 2023
@vmaillot
Copy link
Contributor

vmaillot commented Oct 9, 2023

i am not sure to get why is the pipeline failing hmm @hairmare a clue?

@vmaillot vmaillot dismissed their stale review October 9, 2023 15:09

need to fix the pipeline first

@maxthier
Copy link
Contributor Author

maxthier commented Oct 9, 2023

Pipeline fails because of missing " " I guess. Should be fixed in a few sec.

@maxthier
Copy link
Contributor Author

maxthier commented Oct 9, 2023

Pipeline fails because of missing " " I guess. Should be fixed in a few sec.

Yeah, that was the issue

@maxthier
Copy link
Contributor Author

maxthier commented Oct 9, 2023

I'll merge and test it tomorrow

@maxthier
Copy link
Contributor Author

Tested and works fine

@maxthier maxthier merged commit 94e34b0 into main Oct 10, 2023
3 checks passed
@maxthier maxthier deleted the update-keda branch October 10, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.12.0 of keda is available!
2 participants