fix(keycloak): don't quote poolMinSize value (#1354)

adfinis · Dec 13, 2024 · a283b3f · a283b3f
1 parent ba1c1bd
commit a283b3f
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 20 deletions.
diff --git a/charts/keycloak-operator/Chart.yaml b/charts/keycloak-operator/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: keycloak-operator
 description: Deploy Keycloak Operator and Keycloak
 type: application
-version: 1.4.3
+version: 1.4.4
 appVersion: "26.0.7"
 icon: https://www.keycloak.org/resources/images/logo-stacked.svg
 home: https://www.keycloak.org
@@ -15,8 +15,5 @@ maintainers:
     url: https://adfinis.com
 annotations:
   artifacthub.io/changes: |
-    - kind: changed
-      description: "chore: update keycloak from v26.0.6 to v26.0.7"
-      links:
-        - name: "Keycloak 26.0.7"
-          url: https://www.keycloak.org/2024/12/keycloak-2607-released
+    - kind: fixed
+      description: "fix: don't quote value for poolMinSize as the upstream type is integer"
diff --git a/charts/keycloak-operator/README.md b/charts/keycloak-operator/README.md
diff --git a/charts/keycloak-operator/templates/keycloak/keycloak.yaml b/charts/keycloak-operator/templates/keycloak/keycloak.yaml
@@ -31,7 +31,7 @@ spec:
     poolMaxSize: {{ . }}
     {{- end }}
     {{- with .Values.keycloak.db.poolMinSize }}
-    poolMinSize: {{ . | quote }}
+    poolMinSize: {{ . }}
     {{- end }}
     {{- with .Values.keycloak.db.port }}
     port: {{ . }}

diff --git a/charts/keycloak-operator/tests/__snapshot__/default_test.yaml.snap b/charts/keycloak-operator/tests/__snapshot__/default_test.yaml.snap
@@ -9,7 +9,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloakcontroller-cluster-role
     rules:
       - apiGroups:
@@ -36,7 +36,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloakrealmimportcontroller-cluster-role
     rules:
       - apiGroups:
@@ -63,7 +63,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: RELEASE-NAME-keycloak-operator-operator
     spec:
       replicas: 1
@@ -128,7 +128,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloak-operator-role-binding
     roleRef:
       apiGroup: rbac.authorization.k8s.io
@@ -147,7 +147,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloak-operator-view
     roleRef:
       apiGroup: rbac.authorization.k8s.io
@@ -166,7 +166,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloakcontroller-role-binding
     roleRef:
       apiGroup: rbac.authorization.k8s.io
@@ -185,7 +185,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloakrealmimportcontroller-role-binding
     roleRef:
       apiGroup: rbac.authorization.k8s.io
@@ -204,7 +204,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloak-operator-role
     rules:
       - apiGroups:
@@ -267,7 +267,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: RELEASE-NAME-keycloak-operator-operator
     spec:
       ports:
@@ -290,5 +290,5 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: keycloak-operator
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: RELEASE-NAME-keycloak-operator
diff --git a/charts/keycloak-operator/tests/__snapshot__/operand_test.yaml.snap b/charts/keycloak-operator/tests/__snapshot__/operand_test.yaml.snap
@@ -7,7 +7,7 @@ should match snapshot:
         app.kubernetes.io/component: keycloak
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: keycloak
     spec:
       features:
@@ -34,7 +34,7 @@ should match snapshot:
       labels:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/version: 26.0.7
-        helm.sh/chart: keycloak-operator-1.4.3
+        helm.sh/chart: keycloak-operator-1.4.4
       name: RELEASE-NAME-keycloak-operator-test
     spec:
       keycloakCRName: keycloak