-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add email error handler #575
Conversation
22767c6
to
67c8383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make this handler "opt-in" since not everyone will want this. Please make sure this will only be added if a certain env var is given. Also, the new env vars need to be documented.
67c8383
to
5039b4b
Compare
5039b4b
to
c9b8c9d
Compare
Awesome! Good job 💯 |
@trowik We are integrating django-generic-api-permissions right now. This will lead to extension code that possibly wants to use the django The situation right now could lead to following scenario: I want to send mails from an extension. I use a hacky way of setting the mailing settings in django, but this would implicitly enable email logging. |
@open-dynaMIX Very good point, I didn't think of this when reviewing.. @trowik could you do that? |
@open-dynaMIX you're absolutely right. |
Resolves #571