Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SASU-0127] - Tuist Migration #129 #130

Merged
merged 14 commits into from
Dec 25, 2023

Conversation

batuhanabay
Copy link
Collaborator

Description

Migration to Tuist from XCodeGen in order to use workspaces

Related issue

Related to: #129

Explanation of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes;

  • Update gitignore for Tuist integration

  • Delete project.yml file used for xcodegen project generation

  • Add execute rights(b running this command: chmod +x swiftlint.sh) to swiftlint.sh file to run it from BuildPhase run script

  • TUIST INTEGRATION

    • Create Workspace.swift file in the root directory of the project for tuist

    • Create Tuist/ folder in the root directory of the project

    • Create ProjectDescriptionHelpers/ folder in the Tuist directory and create related helper files that we need in the ProjectDescriptionHelpers/ directory to make tuist build manifests and create "ProjectDescriptionHelpers" framework for us.

    • Create Projects folder to collect each application under the project-by-project Projects directory.

    • Create Project.swift file for SampleAppSwiftUI project under Projects/SampleAppSwiftUI/ directory

    • Create Dependencies.swift and Package.swift file under Tuist/ to fetch swift packages via SPM when running tuist fetch command

    • Folder and directory structure changed for Tuist integration. SampleAppSwiftUI folder moved under the Projects/SampleAppSwiftUI/ directory

    • SampleAppSwiftUI app's Info.plist file moved from the Resources folder to its parent directory which is Projects/SampleAppSwiftUI/SampleAppSwiftUI

    • Constants folder moved to its parent from Resources folder because when defining ResourceFileElements on tuist's Project.swift manifest file, tuist adds all files under the directory to "Copy Bundle Resources" build phase and if there is .swift file on the given folder, Xcode gives warning that it can not copy XYZ.swift file

  • Update README.md with respect to removal of xcodegen and adding Tuist integration

  • Fix swiftlint build errors

  • Refactor ios-build.check.yml to replace xcodegen with tuist on our GitHub actions workflow

Batuhan Abay added 13 commits December 12, 2023 18:09
…project for tuist

[SASU-0127] Create Tuist/ folder in the root directory of the project
[SASU-0127] Create ProjectDescriptionHelpers/ folder in the Tuist directory and create related helper files that we need in the ProjectDescriptionHelpers/ directory to make tuist build manifests and create "ProjectDescriptionHelpers" framework for us.
[SASU-0127] Create Modules folder to collect each application under the project-by-project Modules directory.
[SASU-0127] Create Project.swift file for SampleAppSwiftUI project under Modules/SampleAppSwiftUI/ directory
[SASU-0127] Create Dependencies.swift and Package.swift file under Tuist/ to fetch swift packages via SPM when running tuist fetch command
…ion. SampleAppSwiftUI folder moved under the Modules/SampleAppSwiftUI/ directory

[SASU-0127] SampleAppSwiftUI app's Info.plist file moved from the Resources folder to its parent directory which is Modules/SampleAppSwiftUI/SampleAppSwiftUI
[SASU-0127] Constants folder moved to its parent from Resources folder because when defining ResourceFileElements on tuist's Project.swift manifest file, tuist adds all files under the directory to "Copy Bundle Resources" build phase and if there is .swift file on the given folder, Xcode gives warning that it can not copy XYZ.swift file
… for "SampleAppSwiftUI" target with different configuration combination
… make it able to create single scheme for given target name with different configuration combination

[SASU-0127] Change scheme generation method on createAppModule function to create single scheme for given app name with different configuration combination
…ODUCT_BUNDLE_IDENTIFIER" value by accessing it like "$(PRODUCT_BUNDLE_IDENTIFIER)" on tuist side
…cause it cause confusion

[SASU-0127] Refactor tuist manifest files due to "Modules" folder renaming
@batuhanabay batuhanabay self-assigned this Dec 14, 2023
… try to solve tuist-action fails on GitHub Actions workflow like mentioned in tuist/tuist-action#7
@batuhanabay batuhanabay merged commit e9120ca into develop Dec 25, 2023
1 check passed
@batuhanabay batuhanabay deleted the feature/SASU0127-TuistMigration branch December 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants