Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master & dev branches #795

Merged
merged 12 commits into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ yarn-error.log
testem.log
/typings

# Documentation Styling
frontend/src/assets/documentation/styles/site.css

# environment variables
.env
environment.prod.ts
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ RUN add-apt-repository "deb [arch=amd64] https://packages.microsoft.com/repos/ed
RUN apt-get update && apt-get install -qq -y microsoft-edge-stable

# Install msedgedriver
RUN npm install --ignore-scripts -g edgedriver
RUN npm install --ignore-scripts -g edgedriver node-fetch

# Show Edge and EdgeDriver version
RUN microsoft-edge --version
Expand Down
2 changes: 1 addition & 1 deletion backend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ RUN cat latest_stable.txt
# fi

# Install msedgedriver
RUN npm install --ignore-scripts -g edgedriver
RUN npm install --ignore-scripts -g edgedriver node-fetch

# Show Edge and EdgeDriver version
RUN microsoft-edge --version
Expand Down
3 changes: 1 addition & 2 deletions backend/features/step_definitions/stepdefs.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ edgeOptions.addArguments('--lang=de');
edgeOptions.addArguments('--excludeSwitches=enable-logging');
// chromeOptions.addArguments('--start-fullscreen');

chromeOptions.bynary_location = process.env.GOOGLE_CHROME_SHIM;
let currentParameters = {};

const NotFoundError = (e) => Error(`ElementNotFoundError: ${e}`);
Expand Down Expand Up @@ -623,7 +622,7 @@ Then('So I will be navigated to the website: {string}', async function checkUrl(
const world = this;
try {
await driver.getCurrentUrl().then(async (currentUrl) => {
expect(currentUrl).to.equal(url, 'Error');
expect(currentUrl.replace(/\/$/g, '') == url.replace(/[\s]|\/\s*$/g, '') , 'ERROR expected: ' + url.replace(/[\s]|\/\s*$/g, '') + '; actual: ' + currentUrl.replace(/\/$/g, '')).to.be.true
});
} catch (e) {
await driver.takeScreenshot().then(async (buffer) => {
Expand Down
Loading
Loading