Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in centralized blocks #485

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Conversation

nkarmazina
Copy link
Collaborator

  1. Deleting a block reference works correctly.
  2. Some functions and comments have been renamed for better reading and understanding.

1. Deleting a block reference works correctly.
2.  Some functions and comments have been renamed for better reading and understanding.
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sMeilbeck sMeilbeck self-requested a review October 27, 2023 16:47
@sMeilbeck
Copy link
Collaborator

Zentrale Blöcke werden nach dem Löschen in normale Ausdrücke umgewandelt - falls dies so gewollt ist, ist es mergeable.

Mein Ablauf, dass sie übrig waren: Zentraler Block erstellt; in zwei Szenarien eingefügt; in einem Szenario unpack; in zweitem Szenario auf Block einfügen Ansicht und löschen; in beiden jetzt unpacked. ich nehme an es ist richtig so? Auf jeden Fall, gute Arbeit 👍

Copy link
Collaborator

@sMeilbeck sMeilbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kommentar beachten, ansonsten nach meiner Ansicht mergebar

@nkarmazina nkarmazina merged commit 46adc04 into dev Oct 28, 2023
3 checks passed
@sMeilbeck sMeilbeck deleted the centralized-blocks-upgrade branch November 1, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants