Skip to content

Commit

Permalink
Fix typo, check edge and edgedriver version separately, use npm insta…
Browse files Browse the repository at this point in the history
…ll edgedriver also for backend Dockerfile
  • Loading branch information
sMeilbeck committed Sep 20, 2024
1 parent 932a094 commit 502b1bb
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/Build_and_Publish_Images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
if: ${{ startsWith(github.event.release.name, 'Seed-Test_v') }}
run: docker push ${{ secrets.DOCKER_USERNAME }}/seed-test-demo:latest

- name: Post susccess message
- name: Post success message
uses: ./actions/notifyTeams
with:
title: "Publish Release DockerHub 🐳🌐"
Expand Down
3 changes: 3 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ RUN apt-get update && apt-get install -qq -y microsoft-edge-stable

# Install msedgedriver
RUN npm install -g edgedriver

# Show Edge and EdgeDriver version
RUN microsoft-edge --version
RUN edgedriver --version

# Clean up the cache after installing all necessary packages
Expand Down
19 changes: 13 additions & 6 deletions backend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,19 @@ RUN msedge --version | sed 's/.*Edge \([0-9.]*\).*/\1/' > latest_stable.txt
# Return stable version (debugging purposes)
RUN cat latest_stable.txt

# Download msedgedriver (only if available)
RUN if [ $(wget -qO- https://msedgedriver.azureedge.net/$(cat latest_stable.txt)/edgedriver_linux64.zip) ]; then \
wget -q -O /tmp/msedgedriver.zip https://msedgedriver.azureedge.net/$(cat latest_stable.txt)/edgedriver_linux64.zip && \
unzip /tmp/msedgedriver.zip msedgedriver -d /usr/local/bin/ && \
rm -f /tmp/msedgedriver.zip; \
fi
# # Download msedgedriver (only if available)
# RUN if [ $(wget -qO- https://msedgedriver.azureedge.net/$(cat latest_stable.txt)/edgedriver_linux64.zip) ]; then \
# wget -q -O /tmp/msedgedriver.zip https://msedgedriver.azureedge.net/$(cat latest_stable.txt)/edgedriver_linux64.zip && \
# unzip /tmp/msedgedriver.zip msedgedriver -d /usr/local/bin/ && \
# rm -f /tmp/msedgedriver.zip; \
# fi

# Install msedgedriver
RUN npm install -g edgedriver

# Show Edge and EdgeDriver version
RUN microsoft-edge --version
RUN edgedriver --version


# Remove temporary file (regardless of download success)
Expand Down

0 comments on commit 502b1bb

Please sign in to comment.