Fix catch let error warnings

adamayoung · Nov 28, 2023 · 362be13 · 362be13
1 parent 1574b8d
commit 362be13
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/Tests/TMDbTests/Mocks/Client/MockAPIClient.swift b/Tests/TMDbTests/Mocks/Client/MockAPIClient.swift
@@ -48,13 +48,12 @@ final class MockAPIClient: APIClient {
         do {
             guard let value = try result.get() as? Response else {
                 preconditionFailure("Can't cast response to type \(String(describing: Response.self))")
-//                throw TMDbAPIError.unknown
             }
 
             return value
         } catch let error as TMDbAPIError {
             throw error
-        } catch let error {
+        } catch {
             throw TMDbAPIError.unknown
         }
     }

diff --git a/Tests/TMDbTests/Networking/APIClient/SerialiserTests.swift b/Tests/TMDbTests/Networking/APIClient/SerialiserTests.swift
@@ -39,7 +39,7 @@ final class SerialiserTests: XCTestCase {
 
         do {
             _ = try await serialiser.decode(MockObject.self, from: data)
-        } catch let error {
+        } catch {
             XCTAssertTrue(true)
             return
         }

diff --git a/Tests/TMDbTests/Networking/HTTPClient/URLSessionHTTPClientAdapterTests.swift b/Tests/TMDbTests/Networking/HTTPClient/URLSessionHTTPClientAdapterTests.swift
@@ -53,7 +53,7 @@ final class URLSessionHTTPClientAdapterTests: XCTestCase {
         do {
             let url = try XCTUnwrap(URL(string: "/error"))
             response = try await httpClient.get(url: url, headers: [:])
-        } catch let error {
+        } catch {
             XCTFail("Unexpected error thrown")
             return
         }
@@ -68,7 +68,7 @@ final class URLSessionHTTPClientAdapterTests: XCTestCase {
         do {
             let url = try XCTUnwrap(URL(string: "/error"))
             response = try await httpClient.get(url: url, headers: [:])
-        } catch let error {
+        } catch {
             XCTFail("Unexpected error thrown")
             return
         }
@@ -85,7 +85,7 @@ final class URLSessionHTTPClientAdapterTests: XCTestCase {
         do {
             let url = try XCTUnwrap(URL(string: "/error"))
             response = try await httpClient.get(url: url, headers: [:])
-        } catch let error {
+        } catch {
             XCTFail("Unexpected error thrown")
             return
         }