Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quad encoder Feather ESP32 S2 TFT example #92

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

caternuson
Copy link
Contributor

Adding back quad encoder example using Feather ESP32-S2 TFT shown on product page:
https://www.adafruit.com/product/5752
as requested here:
https://forums.adafruit.com/viewtopic.php?t=204572

@caternuson
Copy link
Contributor Author

@ladyada for review

didn't update any dependencies
GFX gets brought in via existing ST7735 lib dep
was there something else?

@ladyada
Copy link
Member

ladyada commented Sep 20, 2023

you'll need to add esp32 tft feather to the CI list for it to build & verify this demo?

Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok please check the CI but this is now good lookin

@ladyada ladyada merged commit 8068e65 into adafruit:master Sep 20, 2023
10 checks passed
@caternuson
Copy link
Contributor Author

CI looks good. Board added and it actually compile checked the example:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants