-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for float formatting on Arduino UNO Wifi Rev. 2 #97
Conversation
@kintel Compiles OK on my end but I think my pinouts for the ESP32 are incorrect - Could you provide me with two things before I test again:
|
@brentru Yeah, this probably warrants an example as there are some assumptions being made in the existing examples about how groups of preprocessor symbols always being defined together. |
|
|
@brentru My above example may be nice to add as a proper example btw. |
@kintel LGTM, pulling in |
Thanks for rapid turnaround! |
This PR adds support for float formatting on Arduino UNO Wifi Rev. 2.
Since that Arduino variant uses the "megaAVR" core, which has much of the same limitations as regular AVR cores, the
ARDUINO_ARCH_AVR
preprocessor check wasn't sufficient to catch this.This issue was discovered by using said board to post decimal values to Adafruit IO.
Note: This does not add support for board type and board ID - these will still be "unknown" as today.