Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move CancelledError and InvalidStateError to tasks #55

Merged
merged 4 commits into from
Nov 15, 2023
Merged

chore: move CancelledError and InvalidStateError to tasks #55

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
529b01d
chore: move CancelledError and InvalidStateError to tasks
imnotjames Nov 11, 2023
516dc86
chore: clearer comment and tighter error handling
imnotjames Nov 14, 2023
3fd6059
chore: fix grammar in comment about imports
imnotjames Nov 14, 2023
3921b20
chore: move errors into core under the import catch block
imnotjames Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions asyncio/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,27 @@
# Import TaskQueue and Task, preferring built-in C code over Python code
try:
from _asyncio import TaskQueue, Task
except:
except ImportError:
from .task import TaskQueue, Task


################################################################################
# Exceptions


class CancelledError(BaseException):
"""Injected into a task when calling `Task.cancel()`"""
# Depending on the release of CircuitPython these errors may or may not
# exist in the C implementation of `_asyncio`. However, when they
# do exist, they must be preferred over the Python code.
try:
from _asyncio import CancelledError, InvalidStateError
except (ImportError, AttributeError):
class CancelledError(BaseException):
"""Injected into a task when calling `Task.cancel()`"""
pass


pass
class InvalidStateError(Exception):
"""Can be raised in situations like setting a result value for a task object that already has a result value set."""
pass


class TimeoutError(Exception):
Expand Down