Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PoC: add middleware, batch logs, and ship them with uplink #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

adaRn
Copy link
Owner

@adaRn adaRn commented Jun 12, 2024

Change-Id: Ic2b18a93589978c2d95f15b714368be1fc5dea01

PR Checklist

  • The PR title is formatted as follows: pkg/server: add TestXYZ for XYZ
    • The package name goes before the colon
    • The part after the colon uses the verb tense + phrase that completes the blank in, "This change modifies Gateway-MT to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible. Ideally under 72 characters or shorter
    • No Markdown

Commit Message Body

  • What, why, please describe the tests and the performance impact (if any)
  • No Markdown
  • The body is wrapped at 72 characters unless it's really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Closes #1234, Fixes #1234, Resolves #1234 or Updates #1234 (the latter if this is not a complete fix) to this comment
  • If referring to a repo other than storj/edge, you can use the owner/repo#issue_number syntax: Fixes storj/common#1234
  • We do not use Signed-off-by lines. Please don't add them. Our Gerrit server & GitHub bots enforce CLA compliance instead
  • More: https://github.com/storj/docs/blob/main/code/Git.md
  • Delete these instructions once you have read and applied them

Related Issue

Code Review Checklist (to be filled out by reviewer)

  • Are there any authservice's database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs, it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation needs updating?
  • Do the database access patterns make sense?
  • Copy the Commit Message Body section contents into the submit prompt upon PR completion

Adam added 7 commits June 12, 2024 17:05
Change-Id: Ic2b18a93589978c2d95f15b714368be1fc5dea01
Change-Id: I778a726669477da29c81cb6fcbb915ecaccd8433
Change-Id: I40c24fe03db41ce48ba15fb0f2763eba3a480e8a
Change-Id: I7167bf9106f748df48ddbbeba52d0bccc7da96e7
…ture

Change-Id: I559272a9138b130abb45218a813ae139fc6c5ec7
Change-Id: I39bb29537913ed4be5d84b66e21c97a7faf283fe
Change-Id: If923e2d9917dcbcde44d998db099f08eb8131116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant