Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write untagged nodes by default #101

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Write untagged nodes by default #101

merged 3 commits into from
Nov 15, 2024

Conversation

patrickbr
Copy link
Member

This PR removes the option --write-way-node-geometries and handles untagged nodes in exactly the same manner as tagged nodes.

@lehmann-4178656ch lehmann-4178656ch self-requested a review November 14, 2024 10:24
@lehmann-4178656ch
Copy link
Member

Any idea why the non-stdout E2E builds keep failing @patrickbr ?

@patrickbr
Copy link
Member Author

No idea, it seems like a memory issue, maybe caused by the increased input size to QLever (because of the non-tagged nodes). A quick mitigation would be to add options --skip-untagged-nodes, --skip-untagged-ways and --skip-untagged-relations.

@lehmann-4178656ch
Copy link
Member

I'd prefer to switch the test dataset to something smaller first. Looking at https://osm2rdf.cs.uni-freiburg.de/ Malta has (with the old code) ~12.3M triples. Gibralta would have ~3.6M or Greenland ~3.2M. Are there some specific features in Malta we need for the E2E tests?

What I find very interesting is that writing to stdout worked. Granted it does not require memory for decompressing the data, but so should the uncompressed output test which fails.

@patrickbr
Copy link
Member Author

I changed the E2E test dataset to Liechtenstein, let's see what happens.

@lehmann-4178656ch lehmann-4178656ch merged commit 3769c8e into master Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants