Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Gen3 blueprint geometry construction #3869

Draft
wants to merge 67 commits into
base: main
Choose a base branch
from
Draft

feat: Gen3 blueprint geometry construction #3869

wants to merge 67 commits into from
+3,017 −24

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Nov 18, 2024 •
edited
Loading

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2024 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Nov 18, 2024
Merged
Open
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Nov 18, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Nov 18, 2024
@paulgessinger paulgessinger added this to the next milestone Nov 18, 2024
kodiakhq bot pushed a commit that referenced this pull request Nov 22, 2024
@paulgessinger
feat(util): Add overloaded helper (#3816)
edad4c9 
This is useful in combination with `std::visit`. With this, you can do something like 

```cpp
  struct A {};
  std::variant<int, double, A> var;

  var = 42;

  std::visit(overloaded{
                 [](int) { BOOST_CHECK(true); },
                 [](double) { BOOST_CHECK(false); },
                 [](A) { BOOST_CHECK(false); },
             },
             var);
```

which can be convenient.

I'm using this in #3869
@paulgessinger
--------------------------------------------
98b1d3c
@paulgessinger
--------------------------------------------
3f1ead6
@paulgessinger
--------------------------------------------
b0cb1de
@paulgessinger
blueprint: wip building test
63dba82
@paulgessinger
blueprint: basic hierarchy
cde899a
@paulgessinger
blueprint: wip API
fa8e9ff
@paulgessinger
blueprint: example tree
b4993d8
@paulgessinger
blueprint: api exploration
216af92
@paulgessinger
blueprint: api in parts
ba18aba
@paulgessinger
blueprint: add missing headers
8536e3d
@paulgessinger
blueprint: fix to blueprintnode after BinningValueChange
74fb47d
@paulgessinger
blueprint: add missing semicolons
3116be3
@paulgessinger
blueprint: Experimenting with shell implementation
b3e607a
@paulgessinger
blueprint: blueprint tests, currently nullptr access
3a4decd
@paulgessinger
blueprint: some fixes after updates
9d43392
@paulgessinger
blueprint: Use pathlib.Path for obj output
e213f9d
@paulgessinger
blueprint: fix vector instability
dc7168c
@paulgessinger
blueprint: static output improvement
1f50be0
@paulgessinger
blueprint: Uew ViewConfig designated initializers
47700ff
@paulgessinger
blueprint: work on API with root builder node
045afe0
paulgessinger and others added 29 commits December 2, 2024 10:16
@paulgessinger
blueprint: api evolution
d43b48b
@paulgessinger
blueprint: ray test configuration
763d093
@paulgessinger
blueprint: material designator
07b3782
@paulgessinger
blueprint: Material node graphviz shape change
45562fd
@paulgessinger
blueprint: material node name
549232e
@paulgessinger
blueprint: Finalize gets geocontext as well
6c69efc
@paulgessinger
blueprint: Adjust to nav policy factory signature change
2741602
@paulgessinger
blueprint: enum renaming
a2e8428
@paulgessinger
blueprint: Material node fixes
f39ca27
@paulgessinger
blueprint: Layer/Static nodes get policy override
c57944b
@paulgessinger
blueprint: Add logger to NavArgs
163fc53
@paulgessinger
blueprint: Allow setting policy from python
8c9f9e2
@paulgessinger
blueprint: Downgrade WARNINGs for non-problematic merges
3998c2e
@paulgessinger
blueprint: add clearChildren to node
f0cb2fb
@paulgessinger
blueprint: connectOuter -> fill
2ba668f
@paulgessinger
blueprint: Fix incorrect dynamic cast ifs
baca8e7
@paulgessinger
blueprint: Fix shadowing
ff3132d
@paulgessinger
blueprint: Fix extent constructor call
d67ffc6
@paulgessinger
blueprint: Cyl gap policy reg fix
ff3b7f7
@paulgessinger
blueprint: Update after nav API change
b589280
@paulgessinger
blueprint: Rename RootBlueprintNode to Blueprint
f28004f
@paulgessinger
blueprint: Blueprint inherits privately from BlueprintNode
0bf8002
@paulgessinger
blueprint: Update after nav API change
d273bc0
@paulgessinger
rename gen2 blueprint test
a3e41f4
@paulgessinger
rename existing test to API test, remove some lower level tests
e3e2d0d
@paulgessinger
fix material node error check, blueprint api fix
969be1d
@paulgessinger
add better unit test for individual node types
3988103
@paulgessinger
remove some code from the python test
8797d87
@paulgessinger
blueprint: Remove ActsScalar
96b31ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module 🛑 blocked This item is blocked by another item
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
1 participant
@paulgessinger