Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an arguments parameter to execute_script #13

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add an arguments parameter to execute_script #13

wants to merge 1 commit into from

Conversation

Adrian-Tamas
Copy link

@Adrian-Tamas Adrian-Tamas commented Aug 7, 2019 •
edited
Loading

Fix for #12:

  • Add an argument parameter to send to the script for parity with the default Selenium implementation.
  • Document the usage of the excute_script method in the ReadMe

@Adrian-Tamas Adrian-Tamas mentioned this pull request Aug 7, 2019
Open
prschmid
prschmid suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@prschmid prschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm terribly sorry about the delay in getting to this! I must have missed the notification email. Can you please remove the update to the version and then I'll be sure to get it merged in and make a new release with this change. Thanks!

prschmid
prschmid reviewed Sep 30, 2019
View reviewed changes
elementium/__init__.py Outdated Show resolved Hide resolved
@Adrian-Tamas
Copy link
Author

Removed the version bump. Sorry for the late response on my side as well, unfortunately I was busy with other things and did not check on my github :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prschmid prschmid Awaiting requested review from prschmid

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adrian-Tamas @prschmid