Feat: extract session key #324
Conversation
|
@LukeMathWalker looks like @Conni2461 brought some life back into this request? |
|
I'm sorry, I don't have any time for this at the moment and in the near future. |
|
Hey @robjtede @fafhrd91 if Luke doesn't wish to maintain this .. how would PR's like @Conni2461 ever get merged? |
Community reviews are hugely helpful in speeding up maintainers' efforts. I encourage lots of newcomers to get involved on this repo. |
@robjtede, If @Conni2461 rebases this .. would you consider merging it? I was under the impression Luke sort of owned this extra. |
|
From just a quick skim of the diff, I'm not convinced this has enough tests or docs on new public items to demonstrate the use cases it opens up. |
|
I am happy to continue taking care of core maintainance for sessions (security and key functionality), but I don't have bandwidth for more than that right now. |
I agree that i should have written test back in may. I no longer have a usecase for this so i can no longer justify investing time in adding tests/docs. Sorry |
PR Type
Feature
PR Checklist
cargo +nightly fmt).Overview
It wraps the SessionKey String in a secrecy::Secret which is a breaking change for ppl who have implemented their own storage backend. I, e.g., did that and implemented a backend system for fred.rs because fred has sentinel support. If you guys are interested i can also upstream that.
After that it stores the extracted sessionkey in the Session struct which makes it accessible for users.
Closes #306
Closes #307 It basically finishes that PR. I also pulled their commits and squashed them.
I just need that feature, sooner rather than later, so i thought i implement it rather than poking the ppl involved, on the PR/Issue.
CC @miketwenty1
CC @LukeMathWalker