Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some Lint cops to prevent warnings #951

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Jan 4, 2025

Parity with ActiveAdmin to prevent introduction of new warnings

Manually fix a Lint/UselessAssignment warning

Ref: activeadmin/activeadmin#8597

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (bce170c) to head (3741eb3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #951   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          14       14           
  Lines         563      563           
=======================================
  Hits          557      557           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala marked this pull request as draft January 4, 2025 11:19
Parity with ActiveAdmin to prevent introduction of new warnings

Manually fix a `Lint/UselessAssignment` warning

Ref: activeadmin/activeadmin#8597
@tagliala tagliala force-pushed the chore/enable-ambiguous-operator-cop branch from b4eb37f to 3741eb3 Compare January 4, 2025 11:55
@tagliala tagliala changed the title Enable Lint/AmbiguousOperator cop Enable some Lint cops to prevent warnings Jan 4, 2025
@tagliala tagliala marked this pull request as ready for review January 5, 2025 08:19
@tagliala tagliala requested a review from javierjulio January 5, 2025 14:46
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 258c93f into master Jan 5, 2025
22 checks passed
@tagliala tagliala deleted the chore/enable-ambiguous-operator-cop branch January 5, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants