Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Add the edition suffix only when there is a tag. 2. Extract variab… #2840

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ColdWaterLW
Copy link
Collaborator

…les to make the statement more understandable.

关联的 issue

https://github.com/actiontech/sqle-ee/issues/2106

描述你的变更

  1. 提取变量,让makefile更易读
  2. 调整判断语句,只在有tag的时候添加ee或ce后缀

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

assign in @LordofAvernus

…les to make the statement more understandable.
@LordofAvernus LordofAvernus merged commit e19aa34 into main Dec 26, 2024
3 checks passed
@ColdWaterLW ColdWaterLW deleted the fix-issue-ee-2106 branch December 27, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants