-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 2310 #1990
Merged
Merged
Merge 2310 #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix-issue1783
fix func: getTableNameCreateTableStmtMap problem: this function cannot get all of table from a joinStmt fix func: getOnConditionLeftAndRightType problem: this function cannot fit all of colume name from BinaryOperationExpr temporary solution: supports mapping from table alias to table, but the table can only consist of one table @winfredLIN
feat:support redirect to sql_audit list
define apis
1. rule does not support explicit conversion, when there is an explicit conversion, it cannot be judged based on the converted type. 2. the table in the JOIN of rule is composed of multiple tables, column name cannot be used to indexed to the correct table. @winfredLIN
Support 1884
Change to list impl
the connection key contains multiple columns and does not trigger @winfredLIN
chore:change input param compatible front
fix: DMLCheckJoinFieldType rule not triggered
modified: correct spelling of word column
problem: the old version scanner will not filter out empty sql, and will uploaded empty sql, causing empty node after parse error. solution: in sqle server, we filter out SQL files uploaded by scanner with empty SQL content and do not save them to the database. @winfredLIN
fix: empty node after parse cause by empty sql
fix:spell error
fix issue 1965
fix issue 1119
…the where statement of the subquery will also be checked
DMLCheckWhereIsInvalid DMLCheckWhereExistNot DMLCheckWhereExistScalarSubquery DMLCheckFuzzySearch
fix panic && null
LordofAvernus
force-pushed
the
merge-2310
branch
from
November 6, 2023 11:39
5a6e2ed
to
601f64f
Compare
sjjian
reviewed
Nov 7, 2023
sjjian
reviewed
Nov 7, 2023
sjjian
reviewed
Nov 8, 2023
sjjian
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.