fix: DMLCheckJoinFieldType rule not triggered #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix func: getTableNameCreateTableStmtMap problem: this function cannot get all of table from a joinStmt fix func: getOnConditionLeftAndRightType problem: this function cannot fit all of colume name from BinaryOperationExpr temporary solution: supports mapping from table alias to table, but the table can only consist of one table @winfredLIN
winfredLIN
requested review from
taolx0,
sjjian and
ColdWaterLW
and removed request for
taolx0 and
sjjian
1. rule does not support explicit conversion, when there is an explicit conversion, it cannot be judged based on the converted type. 2. the table in the JOIN of rule is composed of multiple tables, column name cannot be used to indexed to the correct table. @winfredLIN
the connection key contains multiple columns and does not trigger @winfredLIN
ColdWaterLW
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1888
fix func: getTableNameCreateTableStmtMap
problem: this function cannot get all of tables from a joinStmt
fix func: getOnConditionLeftAndRightType
problem: this function cannot get all of colume name from BinaryOperationExpr
temporary solution: supports mapping from table alias to table, but the table can only consist of one table
@winfredLIN