Skip to content

Commit

Permalink
[inner-2129] When getKeyVariables, npe occasionally appears in dble.log
Browse files Browse the repository at this point in the history
  • Loading branch information
@wenyh1 @dcy10000
wenyh1 authored and dcy10000 committed Oct 26, 2023
1 parent d5f2b72 commit 5ddd6a8
Showing 1 changed file with 43 additions and 35 deletions.
78 changes: 43 additions & 35 deletions src/main/java/com/actiontech/dble/config/helper/GetAndSyncDbInstanceKeyVariables.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,11 @@ public KeyVariables call() {
while (!isFinish) {
boolean await = finishCond.await(ds.getConfig().getPoolConfig().getHeartbeatPeriodMillis(), TimeUnit.MILLISECONDS);
if (!await) {
fail = true;
isFinish = true;
LOGGER.warn("test conn timeout,TCP connection may be lost");
if (!isFinish) {
fail = true;
isFinish = true;
LOGGER.warn("test conn timeout,TCP connection may be lost");
}
}
}
} catch (InterruptedException e) {
Expand All @@ -86,89 +88,95 @@ public KeyVariables call() {
private class GetDbInstanceKeyVariablesListener implements SQLQueryResultListener<SQLQueryResult<Map<String, String>>> {
@Override
public void onResult(SQLQueryResult<Map<String, String>> result) {
if (result.isSuccess()) {
ds.setTestConnSuccess(true);
keyVariables = new KeyVariables();
keyVariables.setLowerCase(!result.getResult().get(COLUMN_LOWER_CASE).equals("0"));
boolean isSuccess = result.isSuccess();
ds.setTestConnSuccess(isSuccess);
if (isFinish) {
if (fail)
LOGGER.info("test conn timeout, need to resynchronize");
return;
}
KeyVariables keyVariablesTmp = null;
if (isSuccess) {
keyVariablesTmp = new KeyVariables();
keyVariablesTmp.setLowerCase(!result.getResult().get(COLUMN_LOWER_CASE).equals("0"));

keyVariables.setAutocommit(result.getResult().get(COLUMN_AUTOCOMMIT).equals("1"));
keyVariables.setTargetAutocommit(SystemConfig.getInstance().getAutocommit() == 1);
keyVariablesTmp.setAutocommit(result.getResult().get(COLUMN_AUTOCOMMIT).equals("1"));
keyVariablesTmp.setTargetAutocommit(SystemConfig.getInstance().getAutocommit() == 1);

String isolation = result.getResult().get(columnIsolation);
switch (isolation) {
case "READ-COMMITTED":
keyVariables.setIsolation(Isolations.READ_COMMITTED);
keyVariablesTmp.setIsolation(Isolations.READ_COMMITTED);
break;
case "READ-UNCOMMITTED":
keyVariables.setIsolation(Isolations.READ_UNCOMMITTED);
keyVariablesTmp.setIsolation(Isolations.READ_UNCOMMITTED);
break;
case "REPEATABLE-READ":
keyVariables.setIsolation(Isolations.REPEATABLE_READ);
keyVariablesTmp.setIsolation(Isolations.REPEATABLE_READ);
break;
case "SERIALIZABLE":
keyVariables.setIsolation(Isolations.SERIALIZABLE);
keyVariablesTmp.setIsolation(Isolations.SERIALIZABLE);
break;
default:
break;
}
keyVariables.setTargetIsolation(SystemConfig.getInstance().getTxIsolation());
keyVariables.setMaxPacketSize(Integer.parseInt(result.getResult().get(COLUMN_MAX_PACKET)));
keyVariables.setTargetMaxPacketSize(SystemConfig.getInstance().getMaxPacketSize() + KeyVariables.MARGIN_PACKET_SIZE);
keyVariables.setReadOnly(result.getResult().get(COLUMN_READONLY).equals("1"));
keyVariables.setVersion(result.getResult().get(COLUMN_VERSION));
keyVariables.setBackLog(Integer.parseInt(result.getResult().get(COLUMN_BACK_LOG)));
keyVariablesTmp.setTargetIsolation(SystemConfig.getInstance().getTxIsolation());
keyVariablesTmp.setMaxPacketSize(Integer.parseInt(result.getResult().get(COLUMN_MAX_PACKET)));
keyVariablesTmp.setTargetMaxPacketSize(SystemConfig.getInstance().getMaxPacketSize() + KeyVariables.MARGIN_PACKET_SIZE);
keyVariablesTmp.setReadOnly(result.getResult().get(COLUMN_READONLY).equals("1"));
keyVariablesTmp.setVersion(result.getResult().get(COLUMN_VERSION));
keyVariablesTmp.setBackLog(Integer.parseInt(result.getResult().get(COLUMN_BACK_LOG)));

if (needSync) {
boolean checkNeedSync = false;
if (keyVariables.getTargetMaxPacketSize() > keyVariables.getMaxPacketSize()) {
if (keyVariablesTmp.getTargetMaxPacketSize() > keyVariablesTmp.getMaxPacketSize()) {
checkNeedSync = true;
}
if (keyVariables.isTargetAutocommit() != keyVariables.isAutocommit()) {
if (keyVariablesTmp.isTargetAutocommit() != keyVariablesTmp.isAutocommit()) {
checkNeedSync = true;
} else {
ds.setAutocommitSynced(true);
}
if (keyVariables.getTargetIsolation() != keyVariables.getIsolation()) {
if (keyVariablesTmp.getTargetIsolation() != keyVariablesTmp.getIsolation()) {
checkNeedSync = true;
} else {
ds.setIsolationSynced(true);
}

if (checkNeedSync) {
SyncDbInstanceKeyVariables task = new SyncDbInstanceKeyVariables(keyVariables, ds);
SyncDbInstanceKeyVariables task = new SyncDbInstanceKeyVariables(keyVariablesTmp, ds);
boolean synced = false;
try {
synced = task.call();
} catch (Exception e) {
LOGGER.warn("SyncDbInstanceKeyVariables error", e);
}

if (synced) {
ds.setAutocommitSynced(true);
ds.setIsolationSynced(true);
keyVariables.setMaxPacketSize(keyVariables.getTargetMaxPacketSize());
keyVariablesTmp.setMaxPacketSize(keyVariablesTmp.getTargetMaxPacketSize());
}
}
}
} else {
ds.setTestConnSuccess(false);
}

handleFinished();
handleFinished(keyVariablesTmp);
}

private void handleFinished() {
private void handleFinished(KeyVariables keyVariablesTmp) {
lock.lock();
try {
isFinish = true;
finishCond.signal();
if (fail) {
keyVariables = null;
LOGGER.info("test conn timeout, need to resynchronize");
if (isFinish) {
if (fail)
LOGGER.info("test conn timeout, need to resynchronize");
} else {
keyVariables = keyVariablesTmp;
isFinish = true;
}
finishCond.signal();
} finally {
lock.unlock();
}
}
}

}

0 comments on commit 5ddd6a8

Please sign in to comment.