issue 3238 - fix cpu 100% (#3569)

* issue 3238 - fix cpu 100% * issue 3238 - remove useless code
actiontech · Dec 28, 2022 · 078b381 · 078b381
1 parent c68c60b
commit 078b381
Showing 1 changed file with 5 additions and 17 deletions.
diff --git a/src/main/java/com/actiontech/dble/statistic/stat/UserSqlHighStat.java b/src/main/java/com/actiontech/dble/statistic/stat/UserSqlHighStat.java
@@ -7,41 +7,29 @@
 
 import java.util.*;
 import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.locks.ReentrantLock;
 
 public class UserSqlHighStat {
 
     private static final int CAPACITY_SIZE = 1024;
 
     private Map<String, SqlFrequency> sqlFrequencyMap = new ConcurrentHashMap<>();
-
-    private ReentrantLock lock = new ReentrantLock();
-
-
     private StatSqlParser sqlParser = new StatSqlParser();
 
     public void addSql(String sql, long executeTime, long startTime, long endTime) {
         String newSql = this.sqlParser.mergeSql(sql);
         SqlFrequency frequency = this.sqlFrequencyMap.get(newSql);
         if (frequency == null) {
-            if (lock.tryLock()) {
-                try {
-                    frequency = new SqlFrequency();
-                    frequency.setSql(newSql);
-                } finally {
-                    lock.unlock();
-                }
-            } else {
-                while (frequency == null) {
-                    frequency = this.sqlFrequencyMap.get(newSql);
-                }
+            frequency = new SqlFrequency();
+            frequency.setSql(newSql);
+            SqlFrequency tmp = sqlFrequencyMap.putIfAbsent(newSql, frequency);
+            if (tmp != null) {
+                frequency = tmp;
             }
         }
         frequency.setLastTime(endTime);
         frequency.incCount();
         //TODO setExecuteTime has thread safe problem
         frequency.setExecuteTime(executeTime);
-        this.sqlFrequencyMap.put(newSql, frequency);
     }